Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Rename Azure AD to Entra ID #5663

Closed
7 of 8 tasks
MartinM85 opened this issue Nov 13, 2023 · 11 comments
Closed
7 of 8 tasks

Enhancement: Rename Azure AD to Entra ID #5663

MartinM85 opened this issue Nov 13, 2023 · 11 comments
Assignees
Milestone

Comments

@MartinM85
Copy link
Contributor

MartinM85 commented Nov 13, 2023

Hi,

Since Azure Active Directory was renamed to Entra ID recently, does it make sense to start using the term Entra ID in new commands and docs?

Is there any plan for renaming the command prefix aad to entra? Probably a breaking change.

Specs

@milanholemans
Copy link
Contributor

Hi @MartinM85, this is indeed something we have been thinking about. We plan to remove the aad group in v8 next year. Until then we will support it so we don't introduce a breaking change. The plan was to introduce Microsoft Entra ID and support aad simultaneously. However, we wanted to see which abbreviation would be used by people (like AAD). Will it be entra? meid? eid?
@pnp/cli-for-microsoft-365-maintainers, have we decided yet which one we're going to use?

If we decide how the command group should be called, we can start renaming it and add aad as an alias.

@waldekmastykarz
Copy link
Member

meid would be confusing with @me tokens that we've got, so I suggest we don't use that. I think entra might be the best choice, because following the naming guidelines, you should use Entra ID only when referring to Azure Active Directory itself, but when you refer to its elements such as app reg or a user, you say Entra user and Entra app registration without ID

@martinlingstuyl
Copy link
Contributor

martinlingstuyl commented Nov 14, 2023

I'm on board with this. entra seems a good command group name.

The entry in the docs sidebar could be renamed to 'Entra ID (entra)'.

(That is: until we get feature requests for new commands in other entra parts)

@martinlingstuyl martinlingstuyl added this to the v8 milestone Nov 16, 2023
@martinlingstuyl martinlingstuyl removed this from the v8 milestone Nov 16, 2023
@martinlingstuyl martinlingstuyl added needs peer review Needs second pair of eyes to review the spec or PR and removed breaking change labels Nov 16, 2023
@martinlingstuyl
Copy link
Contributor

Ok, so I feel like we reached a decision on entra here. Is it time to get this shipped @pnp/cli-for-microsoft-365-maintainers? I've added some specs to the issue.

@Jwaegebaert
Copy link
Contributor

entra is good for me as well

@garrytrinder
Copy link
Member

+1 entra

@martinlingstuyl martinlingstuyl changed the title Enhancement: Rename Azure AD to Entra ID? Enhancement: Rename Azure AD to Entra ID Nov 16, 2023
@martinlingstuyl martinlingstuyl added help wanted and removed needs peer review Needs second pair of eyes to review the spec or PR labels Nov 16, 2023
@Adam-it
Copy link
Contributor

Adam-it commented Nov 18, 2023

+1 entra

+1

Thanks @martinlingstuyl for taking the lead on this. You rock 🤩

@nicodecleyre
Copy link
Contributor

Can I work on this?

@Adam-it
Copy link
Contributor

Adam-it commented Dec 28, 2023

Can I work on this?

Sure 👍

@nicodecleyre
Copy link
Contributor

Not that this should be included in this PR. But we should also not forget that there are commands with options that include 'aad' in their name

@martinlingstuyl
Copy link
Contributor

That's a very good point!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants