Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: remove X-RequestDigest from spo site hubsite disconnect and spo site hubsite connect command #5940

Closed
MathijsVerbeeck opened this issue Mar 28, 2024 · 2 comments

Comments

@MathijsVerbeeck
Copy link
Contributor

MathijsVerbeeck commented Mar 28, 2024

Hello

Something very minor, but I've noticed that we currently are adding a X-RequestDigest when using the commands spo site hubsite disconnect or connect. This is (as far as I know) not needed for this endpoint, and I've tested this locally and this can be removed.

If this seems to be overkill, then just close the issue. Just a very very small enhancement 😄

I did some short research in the history of the file and noticed that in the past, a CSOM call was used to achieve what we do in the command. This is probably why it was left there.

@MathijsVerbeeck MathijsVerbeeck changed the title Enhancement: remove X-RequestDigest from spo site hubsite disconnect and spo site hubsite connect Enhancement: remove X-RequestDigest from spo site hubsite disconnect and spo site hubsite connect command Mar 28, 2024
@milanholemans
Copy link
Contributor

If we don't need it, I'd say let's get rid of it. Do you want to work on it, or should we open it up?

@MathijsVerbeeck
Copy link
Contributor Author

Feel free to assign me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants