Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated MessageExtension: non static host #58

Closed
RalfBrennscheidt opened this issue Apr 15, 2019 · 2 comments
Closed

Generated MessageExtension: non static host #58

RalfBrennscheidt opened this issue Apr 15, 2019 · 2 comments
Assignees

Comments

@RalfBrennscheidt
Copy link
Contributor

RalfBrennscheidt commented Apr 15, 2019

Hi,

shouldn't the generated MessageExtension rather use the HOSTNAME from the .env instead of a static one which is being asked during the generation ?

If you switch the host in .env when doing local testing or debugging with ngrok it still uses the static value you entered in the initial generation process.

File: /src/messageExtension/templates/src/app/{messageExtensionName}/{messageExtensionClassName}.ts
Line: 15 + 43

@wictorwilen wictorwilen self-assigned this Apr 15, 2019
@wictorwilen
Copy link
Member

Good catch! Committed locally and will push soon, checking all other places as well.

@wictorwilen
Copy link
Member

Fixed in 25a9e9f
Please install the latest preview package to verify it.
Thanks for reporting this and making #yoteams even better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants