Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPFx upgrade script doesn't work if there are spaces in path #688

Closed
phawrylak opened this issue Nov 26, 2018 · 2 comments
Closed

SPFx upgrade script doesn't work if there are spaces in path #688

phawrylak opened this issue Nov 26, 2018 · 2 comments
Labels
bug waiting on response

Comments

@phawrylak
Copy link
Contributor

Upgrade script generated by o365 spfx project upgrade doesn't work correctly when there are spaces in path, because paths are not in quotes and spaces are not escaped.

Also I think that we should emphasize in report that this is shell (sh) script, not PowerShell script.
@waldekmastykarz
Copy link
Member

Do you have more information about which part of the upgrade script doesn't work specifically?

How would you see the focus on bash rather than PowerShell to be emphasized?

@waldekmastykarz
Copy link
Member

Closing due to lack of response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug waiting on response
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@waldekmastykarz @phawrylak