Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes help desc. spo site set. Closes #1768 #1773

Closed
wants to merge 1 commit into from
Closed

Fixes help desc. spo site set. Closes #1768 #1773

wants to merge 1 commit into from

Conversation

arjunumenon
Copy link
Member

Fixes bug - Updated help description for parameter sharingCapability. Closes 1768

This is PR which fixes the help description which was mentioned wrong for the parameter sharingCapability

Linked Issue

Closes #1768

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 87f61c7 on arjunumenon:1768-fix-helpdesc-spositeset into 1cd587b on pnp:master.

@waldekmastykarz
Copy link
Member

Seems like some stray commits were included in your PR. Could you please have another look?

@waldekmastykarz waldekmastykarz marked this pull request as draft August 21, 2020 14:59
@arjunumenon
Copy link
Member Author

That's weird... I hadn't realised that... My bad...

My master branch might have been outdated and would have caused this. I will have a look into that and will fix it up. Sorry for that.

@waldekmastykarz
Copy link
Member

No problem, it could be very well caused by us merging the v3 branch to master.

@arjunumenon
Copy link
Member Author

@waldekmastykarz - There has been an issue in my branch due to the project restructure and my branch was behaving differently after the rebase from the master.

It also had a the faulty commit which was mentioned in THIS REPLY which i deleted and forced-push to the branch. Somehow that had made the PR to be closed.

I have modified the changes required for this issue and have updated in the branch. Do you want to me create another PR for the same. The changes are made in the same branch which is referenced here. Can you advise on that please.

I am sorry since this has caused an issue across.

PS : I have also re-opened the PR

@arjunumenon arjunumenon reopened this Aug 24, 2020
@arjunumenon arjunumenon marked this pull request as ready for review August 24, 2020 11:09
@waldekmastykarz
Copy link
Member

Perfect! Appreciate your help 👏

@waldekmastykarz waldekmastykarz added this to the v3 milestone Aug 31, 2020
@waldekmastykarz waldekmastykarz self-assigned this Sep 2, 2020
waldekmastykarz
waldekmastykarz approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@waldekmastykarz waldekmastykarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! 👏

@waldekmastykarz
Copy link
Member

Merged manually. Thanks again! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waldekmastykarz waldekmastykarz waldekmastykarz approved these changes

Assignees

@waldekmastykarz waldekmastykarz

Labels
pr-merged
Projects
None yet
Milestone
v3
Development

Successfully merging this pull request may close these issues.

Bug report: Help description example wrong for sharingCapability in the command spo site set
3 participants
@arjunumenon @coveralls @waldekmastykarz