Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes spo file get unit tests, clarification on id in the description #497

Closed
wants to merge 1 commit into from
Closed

Fixes spo file get unit tests, clarification on id in the description #497

wants to merge 1 commit into from

Conversation

VelinGeorgiev
Copy link
Contributor

  • Spo file get - 3 unit tests completed, seems someone forgot to complete them.
  • I also changed the description and examples adding the UniqueId word. This might prevent ambiguity around the id since a SPList has ID (int) and UniqueId (GUID).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8fd6d4e on VelinGeorgiev:file-get-fixes into 4b0e372 on SharePoint:dev.

@waldekmastykarz
Copy link
Member

Perfect! Thank you!

@waldekmastykarz waldekmastykarz self-assigned this Jun 19, 2018
@waldekmastykarz
Copy link
Member

Merged manually

@waldekmastykarz waldekmastykarz added this to the v1.4.0 milestone Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@waldekmastykarz waldekmastykarz

Labels
None yet
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@VelinGeorgiev @coveralls @waldekmastykarz