Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next on cached pagination request #3034

Closed
Kalshu opened this issue May 13, 2024 · 3 comments
Closed

Next on cached pagination request #3034

Kalshu opened this issue May 13, 2024 · 3 comments

Comments

@Kalshu
Copy link

Kalshu commented May 13, 2024

Major Version

3.x

Minor Version Number

24.0

Target environment

Browser App (Hosted external to Microsoft 365 platform)

Additional environment details

N/A

Expected or Desired Behavior

Get next on paged request from cache is not undefined

Observed Behavior

Get next on paged request from cache is undefined
image

Steps to Reproduce

Make a call to retrieve the top 20 user from pnp lib
/graph/users?$count=true&$top=20&$select=displayName%2cid%2cdepartment%2cjobTitle%2clocation%2cimageUrl%2cmail&$filter=accountEnabled+ne+false

Make a second call with same args to retrieve the request from the cache

In the result, next is not defined, but hasNext is true
/graph/users?$count=true&$top=20&$select=displayName%2cid%2cdepartment%2cjobTitle%2clocation%2cimageUrl%2cmail&$filter=accountEnabled+ne+false

In 3.21 version, next is defined but return the result from cached request.

I will try to push a minimum env to reproduce this behaviors

@bcameron1231
Copy link
Collaborator

Hi, Unfortunately we do not support pagination with caching. We did for a brief time with 3.21 but it had some negative side effects, so we had to revert it.

We may potentially bring it into version 4.

Duplicate of #2938

@Kalshu
Copy link
Author

Kalshu commented May 14, 2024

Thanks, for this quick response.

We will plan the migration to v4!

@Kalshu Kalshu closed this as completed May 14, 2024
Copy link

github-actions bot commented Jun 1, 2024

This issue is locked for inactivity or age. If you have a related issue please open a new issue and reference this one. Closed issues are not tracked.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants