Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Get-PnPTeamsTeam include weburl #1824

Closed
4ndri opened this issue Apr 30, 2022 · 3 comments · Fixed by #1825
Closed

[FEATURE]: Get-PnPTeamsTeam include weburl #1824

4ndri opened this issue Apr 30, 2022 · 3 comments · Fixed by #1825
Labels
enhancement New feature or request

Comments

@4ndri
Copy link
Contributor

4ndri commented Apr 30, 2022

Is your feature request related to a problem? Please describe.
when getting a team with Get-PnPTeamsTeam, some properties are missing:

https://docs.microsoft.com/en-us/graph/api/resources/team?view=graph-rest-1.0

Property Type Description
webUrl string (readonly) A hyperlink that will go to the team in the Microsoft Teams client. This is the URL that you get when you right-click a team in the Microsoft Teams client and select Get link to team. This URL should be treated as an opaque blob, and not parsed.
createdDateTime dateTimeOffset Timestamp at which the team was created.
internalId string A unique ID for the team that has been used in a few places such as the audit log/Office 365 Management Activity API.

Describe the solution you'd like
add missing properties to Team.cs

/// <summary>
/// the web-url of the team
/// </summary>
public string WebUrl { get; set; }

/// <summary>
/// the internalId of the team
/// </summary>
public string InternalId { get; set; }

/// <summary>
/// date when the team was created
/// </summary>
[JsonConverter(typeof(DateTimeISO8601Converter))]
public DateTime? CreatedDateTime { get; set; }

Describe alternatives you've considered
use Invoke-PnPGraphMethod as discribed in #873

@milanholemans
Copy link
Contributor

Good enhancement!

@4ndri
Copy link
Contributor Author

4ndri commented May 3, 2022

Thanks for the PR!

@gautamdsheth
Copy link
Collaborator

Thanks @4ndri and @milanholemans , have merged the PR and hence closing the issue.
The updated cmdlet will be available from tomorrow's nightly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants