Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Incorrect CompatiblePSEditions for 2.x in module manifest - remove "Desktop" #3170

Closed
fowl2 opened this issue Jun 8, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@fowl2
Copy link
Contributor

fowl2 commented Jun 8, 2023

Version 2.x of this module doesn't support "Desktop" aka .NET Framework/non-"Core" based PowerShell editions.

Therefore "Desktop" should be removed from the CompatiblePSEditions field of the module metadata:

CompatiblePSEditions = @(`"Core`",`"Desktop`")

(perhaps a different script is used for release builds, but I couldn't find it)

If there are further requirements on the minimum supported version of PowerShell, also consider setting PowerShellVersion.

This will prevent the module from being installed or imported, which is vast improvement on the rather inscrutable messages about files not being found we get otherwise.

Previously reported: #3121, #3009, #2969, https://learn.microsoft.com/en-us/answers/questions/1196279/import-module-could-not-load-file-or-assembly-syst

@fowl2 fowl2 added the bug Something isn't working label Jun 8, 2023
@gautamdsheth
Copy link
Collaborator

Done, thanks @fowl2 !

@fowl2
Copy link
Contributor Author

fowl2 commented Jul 24, 2023

@gautamdsheth sorry but I don't think d0e0dce is quite enough - the published module manifest is still missing CompatiblePSEditions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants