Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DateTimePicker switch allowTextInput #1094

Closed
RicoNL opened this issue Jan 17, 2022 · 4 comments · Fixed by #1126
Closed

DateTimePicker switch allowTextInput #1094

RicoNL opened this issue Jan 17, 2022 · 4 comments · Fixed by #1126
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability
Milestone
3.6.0

Comments

@RicoNL
Copy link
Contributor

RicoNL commented Jan 17, 2022

Category

[X] Enhancement

[ ] Bug

[ ] Question

Version

Please specify what version of the library you are using: [ v3.5.0 ]

If you are not using the latest release, please update and see if the issue is resolved before submitting an issue.

Expected / Desired Behavior / Question

Make allowTextinput a setting to switch on/off

This was previously requested in #928 but has been implemented as always on

image

Observed Behavior

Not possible to switch off manual input of date.

Steps to Reproduce

Use the date picker control
@ghost
Copy link

ghost commented Jan 17, 2022

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Jan 17, 2022
@github-actions
Copy link

Thank you for submitting your first issue to this project.

@milanholemans milanholemans mentioned this issue Jan 29, 2022
Merged
@joelfmrodrigues joelfmrodrigues added status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. type:enhancement New feature or enhancement of existing capability and removed Needs: Triage 🔍 labels Jan 29, 2022
@joelfmrodrigues joelfmrodrigues added this to the 3.6.0 milestone Feb 7, 2022
@joelfmrodrigues joelfmrodrigues added status:fixed-next-drop Issue will be fixed in upcoming release. and removed status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. labels Feb 7, 2022
@joelfmrodrigues
Copy link
Collaborator

@RicoNL thanks for the suggestion, a PR has now been merged to add a new property to the control. It will be available from next release (and available now from latest beta release)

@RicoNL
Copy link
Contributor Author

RicoNL commented Feb 8, 2022

Thanks!

@AJIXuMuK AJIXuMuK mentioned this issue Feb 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability
Projects
None yet
Milestone
3.6.0
Development

Successfully merging a pull request may close this issue.

v3.6.0 pnp/sp-dev-fx-controls-react
2 participants
@joelfmrodrigues @RicoNL