Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateTimePicker: Clear Date #1217

Closed
RicoNL opened this issue May 20, 2022 · 3 comments · Fixed by #1262
Closed

DateTimePicker: Clear Date #1217

RicoNL opened this issue May 20, 2022 · 3 comments · Fixed by #1262
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability
Milestone

Comments

@RicoNL
Copy link
Contributor

RicoNL commented May 20, 2022

Category

[X] Enhancement

[ ] Bug

[ ] Question

Version

Please specify what version of the library you are using: [ 3.8.0 ]

Expected / Desired Behavior / Question

When using the DateTimePicker it would be nice to be able to remove a selected date.

Observed Behavior

It is not possible to remove a selectedDate. It is however possible so remove the date by passing in a null value as described in #799 .

Steps to Reproduce

Add a datepicker to a webpart and try to remove the date. No clear button available in the (fluent ui) datepicker itself.

@ghost
Copy link

ghost commented May 20, 2022

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label May 20, 2022
@joelfmrodrigues joelfmrodrigues added status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability and removed Needs: Triage 🔍 labels Jun 3, 2022
@joelfmrodrigues joelfmrodrigues added this to the 3.9.0 milestone Jun 3, 2022
@PeterWCox
Copy link

I'm happy to do this one as a proper first issue :)

@JoelMrodrigues - How should we implement the clear button - as a Fluent UI link or primary button? I think the former is a bit nicer - see below crappy paint sketch...

image

@RicoNL
Copy link
Contributor Author

RicoNL commented Jun 28, 2022

hi @PeterWCox, please be aware that a PR for the clear-button on the datepicker already has been accepted. See #1218 If you see any improvements on that PR, we can discuss it here. Thanks!

@AJIXuMuK AJIXuMuK mentioned this issue Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants