Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What about a modern audio control? #1224

Closed
mmsharepoint opened this issue May 26, 2022 · 3 comments · Fixed by #1262
Closed

What about a modern audio control? #1224

mmsharepoint opened this issue May 26, 2022 · 3 comments · Fixed by #1262
Labels
area:new-control
Milestone
3.9.0

Comments

@mmsharepoint
Copy link
Contributor

mmsharepoint commented May 26, 2022 •
edited
Loading

Category

[X ] Enhancement

[ ] Bug

[ ] Question

Version

Please specify what version of the library you are using: [ latest]

Expected / Desired Behavior / Question

I was thinking if it makes sense to also have a FluentUI-like audio control.
I already implemented one in the following Teams sample:
https://github.com/pnp/teams-dev-samples/tree/main/samples/tab-meeting-record-name
If you agree I could try to share/adjust it for this repo SPFx targeted ...

Audio control
@ghost
Copy link

ghost commented May 26, 2022

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label May 26, 2022
@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Jun 7, 2022

@mmsharepoint - sure, it would be really great to have such a control here!

@AJIXuMuK AJIXuMuK added type:enhancement New feature or enhancement of existing capability area:new-control and removed Needs: Triage 🔍 type:enhancement New feature or enhancement of existing capability labels Jun 7, 2022
@mmsharepoint
Copy link
Contributor Author

Okay, I'll try that one.
Will start soon as I am currently working on another contribution.

@mmsharepoint mmsharepoint mentioned this issue Jun 22, 2022
Merged
@AJIXuMuK AJIXuMuK added this to the 3.9.0 milestone Jun 24, 2022
@AJIXuMuK AJIXuMuK mentioned this issue Jul 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:new-control
Projects
None yet
Milestone
3.9.0
Development

Successfully merging a pull request may close this issue.

v3.9.0 pnp/sp-dev-fx-controls-react
2 participants
@AJIXuMuK @mmsharepoint