SharePoint term store crashes if pageContext has no cultureinfo

[DennisKuhn]

Category

[ ] Enhancement

[x] Bug

[ ] Question

Version

Please specify what version of the library you are using: 3.8.0

Expected / Desired Behavior / Question

Search for a term even if the page has no culture info set.

Observed Behavior

An uncaught exception is thrown:

SPTermStorePickerService.js:471 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'currentUICultureName')
    at SPTermStorePickerService.js:471:50
       (anonymous) @ SPTermStorePickerService.js:471
       Promise.then (async)
       (anonymous) @ SPTermStorePickerService.js:451
       Wt+Y.SPTermStorePickerService.searchTermsByTermSet @ SPTermStorePickerService.js:450
       Wt+Y.SPTermStorePickerService.searchTermsByName @ SPTermStorePickerService.js:322
       (anonymous) @ TermPicker.js:133
       step @ TermPicker.js:45
       (anonymous) @ TermPicker.js:26
       (anonymous) @ TermPicker.js:20
       b7hz.__awaiter @ TermPicker.js:16
       b7hz.TermPicker.onFilterChanged @ TermPicker.js:126
       BasePicker._this._onResolveSuggestions @ BasePicker.js:352
       invokeFunction @ Async.js:310
       callback @ Async.js:335
       resultFunction @ Async.js:364
       kSRW.BasePicker.updateValue @ BasePicker.js:594
       BasePicker._this.onInputChange @ BasePicker.js:77
       9Ow0.Autofill._notifyInputChange @ Autofill.js:267
       (anonymous) @ Autofill.js:109
       pr @ sp-pages-assembly_en-nz_8d7827d88cb39cb2a4596efd3d5f4ef4.js:69

Steps to Reproduce

Use the term picker and search for a term on site without culture info.

[ghost]

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

[DennisKuhn]

submit pull request #1227

[DennisKuhn]

Hello, I have noticed the missing currentUICultureName is caused by me when creating an isolated sp context. Sorry for the hassle.

[joelfmrodrigues]

@DennisKuhn I have just merged your PR. I assume it's still a valid change as it's only checking that the property is valid?

[DennisKuhn]

@joelfmrodrigues yes I think so too. It may avoid similar (user) problems in the future ;-)