Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic form: Fields of type Note don't get disabled #1264

Closed
IRRDC opened this issue Jul 13, 2022 · 2 comments
Closed

Dynamic form: Fields of type Note don't get disabled #1264

IRRDC opened this issue Jul 13, 2022 · 2 comments
Labels
status:fixed-next-drop Issue will be fixed in upcoming release.
Milestone

Comments

@IRRDC
Copy link
Contributor

IRRDC commented Jul 13, 2022

Category

[ ] Enhancement

[x] Bug

[ ] Question

Version

Please specify what version of the library you are using: [3.9.0]

Expected / Desired Behavior / Question

Adding internal field names to the disabledFields property should disable the field when the form is shown.

Observed Behavior

When the internal name of a field of type Note gets added to the disabledFields array it does not get disabled.

@ghost
Copy link

ghost commented Jul 13, 2022

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Jul 13, 2022
@IRRDC
Copy link
Contributor Author

IRRDC commented Jul 14, 2022

I had a look at the code to see if I could fix this myself but am a bit stumped right now. DynamicField.tsx tries to disable the RichText control using this property: isEditMode={disabled} which should be !disabled I believe. But regardless of the field being in the disabledFields property it is always enabled. I debugged the code to the point where the RichText control gets created and verified that it gets created with isEditMode true and false resulting in the same behavior (editable control). So there seems to be a second bug (the first being the missing ! in DynamicField) which is in the RichText control.

@AJIXuMuK AJIXuMuK added status:fixed-next-drop Issue will be fixed in upcoming release. and removed Needs: Triage 🔍 labels Jun 24, 2023
@AJIXuMuK AJIXuMuK added this to the 3.15.0 milestone Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release.
Projects
None yet
Development

No branches or pull requests

2 participants