Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TaxonomyPicker Does not show term set labels in Version 3.10.0 #1299

Closed
Ofer-Gal opened this issue Aug 31, 2022 · 8 comments
Closed

TaxonomyPicker Does not show term set labels in Version 3.10.0 #1299

Ofer-Gal opened this issue Aug 31, 2022 · 8 comments
Labels
status:fixed-next-drop Issue will be fixed in upcoming release.
Milestone

Comments

@Ofer-Gal
Copy link

[ X] Bug

Please specify what version of the library you are using: [ 3.10.0 ] SPFx 1.15.0

Expected / Desired Behavior / Question

the code:

  <TaxonomyPicker allowMultipleSelections={false}
          termsetNameOrID="Document Type" panelTitle="Select Document Type" label="Document Type"
          context={wpContext as any} 
          initialValues={selDocType} placeholder={'Start typing or click the label'}
          onChange={onTaxPickerChange} disabled={!dpcRequest.LockedToMe}
          isTermSetSelectable={false} />

Should show all the labels of the "Document Type" term set to allow selection of one.

Observed Behavior

It just shows the spinner forever
image

I installed 3.9.0 and it works fine now
Thanks!

@ghost
Copy link

ghost commented Aug 31, 2022

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@Perneel
Copy link

Perneel commented Sep 6, 2022

I can confirm this is an issue with 3.10.0

@diabhoil
Copy link

diabhoil commented Sep 9, 2022

I can confirm that. Its not working. Same problem is reported here (https://stackoverflow.com/questions/73645337/sharepoint-framework-spfx-pnp-pnpjs-with-react-taxonomy-picker-not-working) I guess.

When I debug the code there is in the "SPTermStorePickerService.ts" there is a "this.clientServiceUrl" which is always undefined. Don't know where it should be set and where this is happening in the code?

Looks like it was removed here (ea4c4b1#diff-35527a9cbfd12287fbf47b477c5be3f4577810886202ce0e85e11eef1f6591ae)

@SmarterJB
Copy link
Contributor

Hello!
I can confirm aswell that this is the problem, and it seems to be an issue in commit ea4c4b1 where the constructor of the SPTermStorePickerService.ts got changed, and the initialization of the this.clientServiceUrl and this.suggestionServiceUrl got removed!

image

I changed it back to the old constructor and it is working properly!

@Ofer-Gal
Copy link
Author

Thank you.
Will there be a new version for the fix?

@SmarterJB
Copy link
Contributor

I created a PR #1311 which should fix the problem!

@AJIXuMuK
Copy link
Collaborator

The PR has been merged and will be included in the next release.
In a meanwhile you can use beta version

@AJIXuMuK AJIXuMuK added status:fixed-next-drop Issue will be fixed in upcoming release. and removed Needs: Triage 🔍 labels Sep 17, 2022
@AJIXuMuK AJIXuMuK added this to the 3.11.0 milestone Sep 17, 2022
@AJIXuMuK AJIXuMuK closed this as completed Oct 4, 2022
@Ofer-Gal
Copy link
Author

Ofer-Gal commented Oct 4, 2022

Thank You

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release.
Projects
None yet
Development

No branches or pull requests

5 participants