Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilePicker, browsing Site / Doclibs loops and floods SPO Service with requests and causes http 429 #1350

Closed
ferrarirosso opened this issue Nov 4, 2022 · 6 comments
Labels
status:fixed-next-drop Issue will be fixed in upcoming release.
Milestone

Comments

@ferrarirosso
Copy link

Category

[x] Bug

Version

Please specify what version of the library you are using: [ 3.11.0]

Expected Behavior

Use of the FilePicker to browse a document library with at least one document and select the document

Observed Behavior

Open file picker, select Site and then a document library with at least one document causes a flood of requests to the SPO services resulting in HTTP 429 Throttling and temporary tenant disruption.
The user only see data flickering on the screen.

Develop Toolbar Screenshot
Screenshot 2022-11-04 at 11 26 30

Steps to Reproduce

  1. Create a new SPFx Solution, Webpart with the 1.15.2 Version
  2. Follow the offical installation instructions
  3. Implement the default Picker as describe in the official docs
  4. gulp serve --nobrowser
  5. Start your hosted workbench, add you webpart and browse to a site / document library with at least one file.

Please be aware that reproducing these steps may cause some disruption in your tenant !

@ghost
Copy link

ghost commented Nov 4, 2022

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ferrarirosso
Copy link
Author

Fixed in this PR

@AJIXuMuK AJIXuMuK added status:fixed-next-drop Issue will be fixed in upcoming release. and removed Needs: Triage 🔍 labels Nov 4, 2022
@AJIXuMuK AJIXuMuK added this to the 3.12.0 milestone Nov 4, 2022
@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Nov 4, 2022

Thanks to @ferrarirosso this will be fixed in the next release.

@PeterWCox
Copy link

In the meantime you can downgrade to V2 @ferrarirosso which worked for me.

"@pnp/spfx-controls-react": "^2.9.0",

@AJIXuMuK AJIXuMuK mentioned this issue Nov 16, 2022
@erkanch
Copy link

erkanch commented Feb 4, 2023

@AJIXuMuK Has this issue been fixed yet? I'm having the same issue with 3.12 version, too. Browsing to the Site or Your Organization tab and picking a library like Site Assets, results in an infinite loop of RenderListDataAsStream calls and the tenant gets throttled. Also, the issue causes the same folders to be rendered repeatedly.
image

@PeterWCox
Copy link

@erkanch I'm no longer involved in SPFX development, but try downgrading to the package version in my above post - that worked for me at time of posting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release.
Projects
None yet
Development

No branches or pull requests

4 participants