Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev branch serve issue #1555

Closed
Saurabh7019 opened this issue Jun 14, 2023 · 10 comments
Closed

Dev branch serve issue #1555

Saurabh7019 opened this issue Jun 14, 2023 · 10 comments
Assignees
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug

Comments

@Saurabh7019
Copy link

Category

[ ] Enhancement

[x] Bug

[ ] Question

Version

Please specify what version of the library you are using: [ 3.15.0 ]

Expected / Desired Behavior / Question

spfx-fast-serve should serve the project without encountering any warnings or errors.

Observed Behavior

spfx-fast-serve is experiencing a significant number of warnings and errors.

image

Steps to Reproduce

  • Sync the dev branch in your fork with original repo
  • install dependencies
  • execute npm run serve

Thanks!

@ghost
Copy link

ghost commented Jun 14, 2023

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Jun 14, 2023
@github-actions
Copy link

Thank you for submitting your first issue to this project.

@joelfmrodrigues
Copy link
Collaborator

@Saurabh7019 many thanks for raising this. We have recently updated the version of SPFx and we still need to update spfx-fast-serve to the relevant version.
As a workaround, can you please confirm if all works with gulp serve ?

@Saurabh7019
Copy link
Author

Thank you! gulp serve works fine. I will use that instead.

@joelfmrodrigues
Copy link
Collaborator

@Saurabh7019 I had a look into this and think I found a fix. Could you please get the latest from the dev branch, run npm install (added a new dev dependency), and try npm run serve again?

@joelfmrodrigues
Copy link
Collaborator

@s-KaiNet Sorry to mention you here, but thought you may be interested to look into this. Using fast-serve, there was an issue related to File and Directory Entries API. Only came up today, so possibly related to the latest SPFx version updates.

I think I have resolved it by adding relevant types and also adding a reference of those types within the tsconfig.json file. Not sure if this is how it should be or if this is something you would prefer to handle on the fast-serve side. Any input/thoughts would be appreciated 🙂

Commit with changes for reference: 178234d

@joelfmrodrigues joelfmrodrigues added the status:fixed-next-drop Issue will be fixed in upcoming release. label Jun 14, 2023
@Saurabh7019
Copy link
Author

@Saurabh7019 I had a look into this and think I found a fix. Could you please get the latest from the dev branch, run npm install (added a new dev dependency), and try npm run serve again?

Thank you, Joel. I have tested it and can confirm that the fix works.

@s-KaiNet
Copy link
Contributor

Hi, thank you for the info! For me, it looks more like project-specific configuration, also in fast-serve I do not touch config files, like tsconfig.json. Thus I assume that this "fix" should be added, if you need to work with files api and not in the fast-serve core.

@joelfmrodrigues
Copy link
Collaborator

@s-KaiNet thanks for the input, appreciated 🙂

@joelfmrodrigues
Copy link
Collaborator

New release just published, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Projects
None yet
Development

No branches or pull requests

3 participants