Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

People Picker Disabled doesn't work #484

Closed
enti333 opened this issue Feb 23, 2020 · 10 comments
Closed

People Picker Disabled doesn't work #484

enti333 opened this issue Feb 23, 2020 · 10 comments
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Milestone

Comments

@enti333
Copy link

enti333 commented Feb 23, 2020

[ ] Enhancement
[X] Bug
[ ] Question

Hello. I don't know why but when I use people picker control and set the property disabled to true I am still able to click on X icon a remove users from people picker....
It happen in all version of pnp react.

Hmm... Thank you for your help.

@ghost
Copy link

ghost commented Feb 23, 2020

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Feb 23, 2020
@github-actions
Copy link

Thank you for submitting your first issue to this project.

@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Mar 1, 2020

Hi @enti333,
This is a known issue of underlying Office UI Fabric React control. Here is the description.
It has been fixed in version 6.129.0.
We have plans on upgrading used version of OUIFR. After that the issue will be fixed.

@fonbrauzen
Copy link

Hi, @AJIXuMuK do you have any estimations, when the update to OUIFR v6.129.0+ could happen?

@Steven-Chorkawy
Copy link

Hello,

I've also run into this bug.
Has there been any update on it?

@AJIXuMuK
Copy link
Collaborator

Hi all,

There is already v2 beta version.

We plan to release it next week.

@AJIXuMuK AJIXuMuK added this to the 2.0.0 milestone Sep 18, 2020
@AJIXuMuK AJIXuMuK added status:fixed-next-drop Issue will be fixed in upcoming release. and removed status:to-be-reviewed labels Sep 18, 2020
@holylander
Copy link

I still see this issue on going. The picker will be disabled, but if there is any user already setup on the control, any will be able to delete such record

@jduysen
Copy link

jduysen commented Mar 3, 2023

For anyone finding this in 2023 who is still using older versions of these libraries because of being on Sharepoint 2019, I resolved this with a workaround in my dynamic form component. Essentially just surrounded the people picker with a div with a conditional style for pointer events. This effectively disables the people picker so the name cannot be removed if the people picker is supposed to be disabled.
Example:
<div style={this.props.disabled?{"pointerEvents": "none"}:{}}><PeoplePicker/><div>

@NMarkovic98
Copy link

For anyone finding this in 2023 who is still using older versions of these libraries because of being on Sharepoint 2019, I resolved this with a workaround in my dynamic form component. Essentially just surrounded the people picker with a div with a conditional style for pointer events. This effectively disables the people picker so the name cannot be removed if the people picker is supposed to be disabled. Example: <div style={this.props.disabled?{"pointerEvents": "none"}:{}}><PeoplePicker/><div>

Thanks! You saved me hours of researching!

@jduysen
Copy link

jduysen commented Sep 19, 2023

@NMarkovic98, glad it helped!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Projects
None yet
Development

No branches or pull requests

7 participants