Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.17.0 - Cannot find module '@pnp/spfx-controls-react/lib/ComboBoxListItemPicker - #509

Closed
siddharth-vaghasia opened this issue Mar 24, 2020 · 8 comments
Labels
area:documentation status:fixed-next-drop Issue will be fixed in upcoming release.
Milestone

Comments

@siddharth-vaghasia
Copy link
Contributor

Category

[ ] Enhancement

[x ] Bug

[ ] Question

Version -

Please specify what version of the library you are using: [ 1.17.0 ]

"@pnp/spfx-controls-react": "^1.17.0-beta.b815cd4",

Screenshot of package.json file

image

Observed Behavior

I was trying new version 1.17.0 and while importing ComboBoxListItemPicker we are getting below error.

image

Used below command to install the latest package

npm i @pnp/spfx-controls-react@next

Please note that IconPicker is working fine and import is also successful.

Further Analysis from my side, not sure if below will help.

  1. Inside node_module/@pnp/spfx-controls-react, we don;t see comboboxlistitempicker folder.

image

  1. As per the source repo code, Combobox list item picker is supposed to be inside listitemPicker folder which is also missing in the that folder also(refer above screenshot).

image

Thanks!
Siddharth

@ghost
Copy link

ghost commented Mar 24, 2020

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Mar 24, 2020
@siddharth-vaghasia siddharth-vaghasia changed the title Cannot find module '@pnp/spfx-controls-react/lib/ComboBoxListItemPicker Version 1.17.0 - Cannot find module '@pnp/spfx-controls-react/lib/ComboBoxListItemPicker - Mar 24, 2020
@joelfmrodrigues
Copy link
Collaborator

@siddharth-vaghasia I believe there is an issue with the package as it no longer seems to be listed on npm.
I had the same problem when updating a sample project from using the beta version to v1.17.
Elio is already aware :)

@joelfmrodrigues
Copy link
Collaborator

@siddharth-vaghasia check the version installed on your package.json, in my case was using 1.16
If so, uninstall and run the install command again to install 1.17 as Elio has now resolved the publishing issue.
This worked for me

@PrasadKasireddy
Copy link
Contributor

@joelfmrodrigues -this issue is still appearing I installed the latest v1.17 however, I can not find the @pnp/spfx-controls-react/lib/ComboBoxListItemPicker'

image

image

@siddharth-vaghasia
Copy link
Contributor Author

@joelfmrodrigues .....yes...working now...thanks..!!! though we have to update the documentation at https://github.com/SharePoint/sp-dev-fx-controls-react/edit/master/docs/documentation/docs/controls/ComboBoxListItemPicker.md ...
Import statement should be as follow

import { ComboBoxListItemPicker } from '@pnp/spfx-controls-react/lib/listItemPicker';

@siddharth-vaghasia
Copy link
Contributor Author

@joelfmrodrigues -this issue is still appearing I installed the latest v1.17 however, I can not find the @pnp/spfx-controls-react/lib/ComboBoxListItemPicker'

image

image

use below import statement

import { ComboBoxListItemPicker } from '@pnp/spfx-controls-react/lib/listItemPicker';

@AJIXuMuK
Copy link
Collaborator

Thank you @siddharth-vaghasia for reporting and fixing!
The fix will be available in the next version.

@siddharth-vaghasia
Copy link
Contributor Author

thanks..closing issue now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:documentation status:fixed-next-drop Issue will be fixed in upcoming release.
Projects
None yet
Development

No branches or pull requests

4 participants