Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListView Control Sticky Header scrolling issue #734

Closed
ragu64 opened this issue Nov 17, 2020 · 19 comments
Closed

ListView Control Sticky Header scrolling issue #734

ragu64 opened this issue Nov 17, 2020 · 19 comments
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Milestone

Comments

@ragu64
Copy link

ragu64 commented Nov 17, 2020

Category

[ ] Enhancement

[X] Bug

[ ] Question

Version

Please specify what version of the library you are using: [2.1.0]

Expected / Desired Behavior / Question

With sticky header feature enable in the PnP ListView control with more 80 items, scrolling items missing (large blank zone). It's seems a render problem (on Chrome browser press F12 twice, the missing items magically reappears).

Thanks!
PnPJS Issue 734

@ghost
Copy link

ghost commented Nov 17, 2020

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Nov 17, 2020
@aaclage
Copy link
Contributor

aaclage commented Nov 18, 2020

Hi @ragu64

I try with 100 items and was not able to retrieve this error, this only happens in the filter or when you list all?

@ragu64
Copy link
Author

ragu64 commented Nov 18, 2020

I have three fields (as you can see in attached image), it's happen always.
The button 'load more...' simply append 10 random items at time.
Without sticky header or using Fluent UI DetailsList it's works fine.

@aaclage
Copy link
Contributor

aaclage commented Nov 18, 2020

Did you try to load all in the sticky header without the append 10 random items and happen the same error?

@ragu64
Copy link
Author

ragu64 commented Nov 18, 2020

Same error. I think is SharePoint Online effect in local (non SPO) it's works fine.

@ragu64
Copy link
Author

ragu64 commented Nov 18, 2020

This is my react component used in my spfx test webpart:

Action.tsx.txt

@AJIXuMuK
Copy link
Collaborator

Hi @ragu64,

I can't repro your issue. I used your code to create a web part and it behaves correctly:
Screen Shot 2020-11-20 at 4 34 04 PM

@AJIXuMuK
Copy link
Collaborator

Could you try beta version of the library?

@ragu64
Copy link
Author

ragu64 commented Nov 25, 2020

Hi, with more than 80 items the issue recurs

@ragu64
Copy link
Author

ragu64 commented Nov 25, 2020

Could you try beta version of the library?

In beta version the stickyHeader property is disappered.

@AJIXuMuK
Copy link
Collaborator

@ragu64 - I just double-checked, the property is still there.
Could you please check what version of the library you have in package.json file?

@ragu64
Copy link
Author

ragu64 commented Dec 1, 2020

@ragu64 - I just double-checked, the property is still there.
Could you please check what version of the library you have in package.json file?

You are right, the property stickyHeader is still there, sorry.
after install spfx-controls-react beta in my solution:
npm install @pnp/spfx-controls-react@next --save

this is the version in my package.json:
"@pnp/spfx-controls-react": "^2.2.0-beta.056c6d9",

@aaclage
Copy link
Contributor

aaclage commented Dec 8, 2020

Ok i found the issue, The List View uses the DetailsList and this one uses lazy loading "Load Content by blocks of 100 or around that" only when default vertical scroll "From Page" the content of ListView is refresh by blocks. The fixe-header doesn't activate the Page scroll and cannot refresh because header is fix only by scroll. I will try to see if the refresh block can be call when scroll with fix header to get the content of that block.

@AJIXuMuK
Copy link
Collaborator

@aaclage - what if we go back to the implementation with ScrollablePane?

@aaclage
Copy link
Contributor

aaclage commented Dec 12, 2020

@AJIXuMuK
i will try that.

@aaclage
Copy link
Contributor

aaclage commented Dec 12, 2020

@AJIXuMuK
Ok works with ScrollablePane implementation and with the lazy loading, i will revert to that control.

@aaclage
Copy link
Contributor

aaclage commented Dec 12, 2020

@AJIXuMuK PR create with the revert to ScrollablePane.

@AJIXuMuK
Copy link
Collaborator

Thank you @aaclage!
The PR has been merged and will be available in the next release.

In a meanwhile you can test the functionality in beta version

@AJIXuMuK AJIXuMuK added status:fixed-next-drop Issue will be fixed in upcoming release. and removed Needs: Attention 👋 labels Dec 13, 2020
@AJIXuMuK AJIXuMuK added this to the 2.3.0 milestone Dec 13, 2020
@ragu64
Copy link
Author

ragu64 commented Dec 14, 2020

Thank you guys, now ListView stickyHeader={true} in PnP Controls 2.3.0-beta, works fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Projects
None yet
Development

No branches or pull requests

3 participants