Taxonomy picker - useSessionStorage property integration

[Whiteshark57]

Category
[x] Enhancement

[ ] Bug

[ ] Question

Version

Please specify what version of the library you are using: [1.21.1]

Expected / Desired Behavior / Question

Could you please update the taxonomy picker control to integrate the useSessionStorage property as it is in the 3.2.1 version?

Observed Behavior

In version 1.21.1, the taxonomy picker control doesn't have the useSessionStorage property available.

Steps to Reproduce

1- Configure a taxonomy picker control.
2- Try to use the useSessionStorage property.

[ghost]

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

[Whiteshark57]

Hi there. Do you have any update on this request?

[AJIXuMuK]

Hi @Whiteshark57,

We're not actively working on features in v1.
But will be happy to review a PR with needed changes if you submit one!

[Whiteshark57]

Hi @AJIXuMuK,

I've implemented the useSessionStorage property as requested.

Unfortunately, while trying to build the project, I have an error [ts] Property 'findIndex' does not exist on type 'string[]'.
This error occurs on a recently updated helper LocalesHelper.ts.

Looking on internet I found that findIndex is used on es6 library while the project is target to es5 one (see below tsconfig.json content).

From my readings I saw it's possible to compile the project using --lib "es6" argument without modifying the tsconfig.json file.
Could you please advise me on this point? I'm new on typescript.

Thanks in advance.

[AJIXuMuK]

Hi @Whiteshark57 - than you for the effort!

You need to use either polyfill or custom implementation to replace findIndex.
You shouldn't change to es6.

[Whiteshark57]

Hi @AJIXuMuK,

I completed the useSessionStorage property implementation.
In the same time I implemented the onPanelSelectionChange and selectChildrenIfParentSelected ones.

Questions for next step:
Do I have to update the change log and release notes? (I don't think so)
What is the process to request the merge of my local branch to the v1-dev one? Currently, I only have a local branch created from the v1-dev one.

Thanks in advance for your feedback.

[AJIXuMuK]

Hi @Whiteshark57 - that's great!
You don't need to update change log or release notes.

For the contribution - you need to do the next steps:

• you should fork the repo (I believe, this is done)
• create your branch based on v1-dev - this is probably done as well
• when the feature is implemented, push it to the origin
• after that you'll be able to create a PR in our repo
• select v1-dev as a target branch.

[Whiteshark57]

Hi @AJIXuMuK,

Created PR #1052 on v1-dev branch as requested.

[joelfmrodrigues]

@Whiteshark57 just doing some house cleaning...could you please confirm if this issue is now resolved?

[Whiteshark57]

@joelfmrodrigues
Hi, yes I confirm this issue is resolved.
See you.

[joelfmrodrigues]

@Whiteshark57 many thanks for confirming, will close this issue