Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] [ListItemComments] Add a parameter to highlight the specified comment to support "Go to Comment" link in Comment Notification #1430

Closed
wuxiaojun514 opened this issue Jan 28, 2023 · 4 comments
Labels
type:enhancement New feature or enhancement of existing capability

Comments

@wuxiaojun514
Copy link
Contributor

Category

[x] Enhancement

[ ] Bug

[ ] Question

Version

Please specify what version of the library you are using: [3.12 ]

Behavior in OOTB List Item Comment

When you @Someone in list item comment, he/she will get a notification in outlook like this
image
Then this user can go to this specified comment directly by click "Go to Comment" button in the mail.
The comment will be highlighted with light blue background color (Perhaps it uses color in theme) in this "Go to Comment" link.
image
The "Go to Comment" link is like https://testxxx.sharepoint.com/sites/xxxx/Lists/Project/DispForm.aspx?ID=1&commentId=1&e=LURoEsg5Zki4cS4SgcIG7w&at=15&CT=1674882847351&OR=OWA-NT&CID=c3a04ee0-40b5-9591-e6a4-3fac33046a64, which contains commentId in url parameter

Expected

Right now I am using ListItemComments control in Form Customization. The comment whose id is in Go to Comment link won't be highlighted on ListItemComments. So it is hard to figure out which comment is mentioned in the notification.
So I want to add an optional parameter to render the specified comment with different background color. We can call this parameter "highlightedCommentId".
Developer can fetch commentId in url parameter first, then use this new parameter to highlight comment.

I can try to implement this enhancement.
We can have discussion here if there is better idea to handle this kind of scenario.

Thanks!

@ghost
Copy link

ghost commented Jan 28, 2023

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Jan 28, 2023
@github-actions
Copy link

Thank you for submitting your first issue to this project.

@AJIXuMuK
Copy link
Collaborator

@wuxiaojun514 - it is a great idea!
Feel free to create a PR and we can review it.

Thanks!

@AJIXuMuK AJIXuMuK added type:enhancement New feature or enhancement of existing capability and removed Needs: Triage 🔍 labels Jan 30, 2023
@wuxiaojun514
Copy link
Contributor Author

Thank you. I will find some time to implement it.

wuxiaojun514 pushed a commit to wuxiaojun514/sp-dev-fx-controls-react that referenced this issue Feb 1, 2023
@wuxiaojun514 wuxiaojun514 mentioned this issue Feb 1, 2023
joaojmendes added a commit that referenced this issue Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or enhancement of existing capability
Projects
None yet
Development

No branches or pull requests

2 participants