Target Audience or Evaluation property controls

[edarroudi]

Category

• Enhancement

Version

Please specify what version of the library you are using: [3.2.0]

Desired Behavior

Coming from pnp-modern-search, I want to add a Property Control where the user can add some evaluation rules based on a internal object that has a token structure. Based on the result of the evaluation, the webpart should be hidden or shown.
Originally I planned to just add the code in the webparts of modern search but @wobba, a maintainer, forwarded me here - he probably saw more use than me in the "control". Here is a link where I describe the solution: microsoft-search/pnp-modern-search#2047

I just used PropertyFieldCollectionData there.

Generally I think there is a need for Audience Targeting because it is very useful to control your webpart. In this case I think we might have to different issues / controls:

a) An Evaluation UI Property Menu

This would look someting like this:

I don't know how useful it would be. Maybe if it is implemented with a tree control and lets users create more complex And / Or based evaluations? Maybe you pass an evaluation token context and the control checks for tokens the user adds to the evaluation rules and if there is some spelling problem or a token doesn't exit, we get a warning / valdiation error? Or maybe an autocomplete feature?

b) An Evaluation Hide/Show Control that takes a ruleset and hides the webpart if the rule is evaluated to false.

Sorry, I know this might be a confusing request - I didn't think of coming here and requesting this - but since @wobba suggested it I will give it a try. Maybe you guys get an idea - I would implement this.

[ghost]

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

[joelfmrodrigues]

@edarroudi Thanks for the suggestion. I agree with Mikael, it would be a nice new control to have in the library and then you could just re-use it inside PnP search web parts.
A tree view control would be very nice 🙂 But really up to you if you prefer to start with a version like the screenshots above or try going for the full support of And / Or.
Please let me know if you are still interested in implementing this and I will assign this item to you to prevent others from working on it at the same time.

[edarroudi]

Thanks for the reply @joelfmrodrigues . I'll gladly do it - probably the treeview version. You can assign it to me and I start asap on a preview version. We can discuss the features / interface of the preview version then...

[joelfmrodrigues]

@edarroudi many thanks and no rush from our side 🙂 We will review it whenever it's ready

[edarroudi]

hey @joelfmrodrigues I created a draf PR since I'm not finished but I would like to discuss some features / interface. Would you mind having a look?

[joelfmrodrigues]

@edarroudi sorry for the late reply, really busy at my end recently and was unable to keep up with everything
Will try to review over the next days