Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiles Web-Part issue in Safari Browser #16

Closed
1 of 3 tasks
patrickabel opened this issue Jun 4, 2018 · 6 comments
Closed
1 of 3 tasks

Tiles Web-Part issue in Safari Browser #16

patrickabel opened this issue Jun 4, 2018 · 6 comments

Comments

@patrickabel
Copy link
Contributor

Category

  • Question
  • Bug
  • Enhancement

Expected or Desired Behavior

I would expect that the PnP Tiles web-part would render in three columns in Safari just like it does in Edge, Chrome, etc. Perhaps this is a display: flex issue?

Observed Behavior

When using the Safari web-browser, the Tiles web-part is wrapping one tile to its own line instead of a consistent three-column layout.
pnp-tiles-web-part-safari-issue

Steps to Reproduce

  1. Deploy and configure sp-starter-kit
  2. View the Tiles web-part in Safari
@LouFarho
Copy link

I was able to reproduce this issue in Safari using iOS 11.4 on a iPhone 7

@AHCFMELO
Copy link

any update on this? i too am having this problem

@patrickabel
Copy link
Contributor Author

@LouFarho @AHCFMELO I was able to resolve this with some CSS updates to the solution. Just update your .tilesList class in Tiles.module.scss to the following:

.tilesList { @include ms-Grid-row; /* display: flex; */ display: block; flex-wrap: wrap; }

Changing the display property to block doesn't negatively affect the web-part across Chrome, Edge, Firefox, etc but resolves the Safari issue.

Good Luck!

@eoverfield
Copy link
Collaborator

@patrickabel thank you for sharing the fix. I will test this out and add to codebase if that is ok with you. or please make a PR if you have a moment.

@patrickabel
Copy link
Contributor Author

@eoverfield I've submitted a PR. Thanks!

@eoverfield
Copy link
Collaborator

This issue was solved via a merged PR. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants