Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pnpm 7 support #38

Open
gunta opened this issue Apr 25, 2022 · 6 comments
Open

Pnpm 7 support #38

gunta opened this issue Apr 25, 2022 · 6 comments

Comments

@gunta
Copy link

gunta commented Apr 25, 2022

Checking here I can see the install script is using https://get.pnpm.io/v6.16.js

const response = await fetch('https://get.pnpm.io/v6.16.js')

Given that the latest 7 version is using https://get.pnpm.io/install.sh as the new install script, is there any change for the process? I can see that the new script is very simple and basically downloads the binary from npm.

@nicksrandall
Copy link

The caching examples will need to be updated as the store is now in a new location.

@benmccann
Copy link

I don't get it. Why do fetch('https://get.pnpm.io/v6.16.js') at all for users who have specified packageManager in the package.json? It'd be nice if that field could be used without first downloading a file from a hardcoded version

@zkochan
Copy link
Member

zkochan commented May 12, 2022

That file is only used to install pnpm. https://get.pnpm.io/v6.16.js will not install pnpm v6.16.

@michaelhays
Copy link

FYI, this action is working with pnpm 7 for me, using these steps: https://pnpm.io/continuous-integration#github-actions

@axelboc
Copy link

axelboc commented May 25, 2022

Working for me too with the example on the pnpm website, which uses action/setup-node's built-in caching feature. This repo's README should probably be updated accordingly. I would just add --frozen-lockfile to the dependencies installation step, though, like in this example from action/setup-node.

@tksst
Copy link
Contributor

tksst commented Mar 29, 2023

It seems like this issue should be closed because pnpm/action-setup works fine with pnpm@7 and pnpm@8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants