Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example not working on all architecture? #61

Closed
melMass opened this issue Oct 18, 2022 · 4 comments
Closed

Example not working on all architecture? #61

melMass opened this issue Oct 18, 2022 · 4 comments

Comments

@melMass
Copy link
Contributor

melMass commented Oct 18, 2022

Hi,

The sample in the readme works for most platforms but not windows:
https://github.com/mtb-tools/vscode-mono-workspace/actions/runs/3269716040

image

This part is the culprit:

- name: Get pnpm store directory
        id: pnpm-cache
        run: |
          echo "STORE_PATH=$(pnpm store path)" >> $GITHUB_OUTPUT 
@KSXGitHub
Copy link
Collaborator

Can you help try adding shell: bash to the step. If it works, I'll welcome a pull request.

@melMass
Copy link
Contributor Author

melMass commented Oct 18, 2022

Thanks, I did try pwsh but not bash! I should have...

I'm preparing a PR right now for the readme.

I basically had two issues:

  1. Shell expansion (your tricks might work, but using gh syntax is safer I guess, we can talk about it in the PR)

  2. Node-GYP is not thread safe, at least on windows, doing this: pnpm causes node-gyp rebuild failures pnpm#2135 (comment) worked.

@melMass
Copy link
Contributor Author

melMass commented Oct 18, 2022

Well partly, but I don't think it's related to this issue specifically:
image

@melMass
Copy link
Contributor Author

melMass commented Oct 18, 2022

Closing in favor of #62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants