Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linked packages should have folder name which is used by dependant's package.json #1364

Closed
KSXGitHub opened this issue Sep 8, 2018 · 3 comments
Assignees

Comments

@KSXGitHub
Copy link
Contributor

KSXGitHub commented Sep 8, 2018

TL;DR

When I write a different name (from dependency's own package.json) in dependencies field, I expect that name to be importable.

Steps to reproduce

1. Create a monorepo structure

Folder Structure

1.1. File dependant/package.json

{
  "name": "dependant",
  "private": true,
  "version": "0.0.0",
  "dependencies": {
    "new-name": "file:../dependency"
  }
}

1.2. File dependency/package.json

{
  "name": "old-name",
  "private": true,
  "version": "0.0.0"
}

2. Link them together

pnpm recursive link

Expected behavior

pnpm creates a symlink at dependant/node_modules/new-name.

Actual behavior

pnpm creates dependant/node_modules/old-name instead.

PNPM

Notes

  • Yarn not only creates new-name but also old-name and dependant, however, I don't think old-name and dependant should be created at all. image
@zkochan
Copy link
Member

zkochan commented Sep 9, 2018

🚢 2.15.2

@KSXGitHub
Copy link
Contributor Author

KSXGitHub commented Sep 10, 2018

Wait, why is pnpm still 2.15.1 in npmjs.com?

image

Nevermind, pnpm@next

@zkochan
Copy link
Member

zkochan commented Sep 10, 2018

yep, we don't make new versions latest immediately. If you need updates earlier, install with the next or rc tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants