Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic network-concurrency #1572

Open
zkochan opened this issue Dec 21, 2018 · 2 comments
Open

Automatic network-concurrency #1572

zkochan opened this issue Dec 21, 2018 · 2 comments

Comments

@zkochan
Copy link
Member

zkochan commented Dec 21, 2018

As of v2.22.0, pnpm uses network-concurrency 16 by default. However, in some environments, that might be too agressive, as we've seen in #1230.

pnpm should automatically decrease concurrency when fetching of a tarball fails. On the first failure, network concurrency should be decreased to 4. If a second failure happens, the network concurrency should be decreased to 1.

This logic should be the default and only used if the adjust-network-concurrency is not set or set to true.

cc @pgonzal

@zkochan
Copy link
Member Author

zkochan commented Dec 23, 2018

Decreasing network concurrency might be a bad idea for pnpm server, so network concurrency should be reset after 60 seconds to the original value.

cc @etamponi

@zkochan zkochan pinned this issue Dec 25, 2018
@octogonz
Copy link
Member

octogonz commented Jan 8, 2019

Thanks for looking into this! FYI we still get occasional error reports about the "integrity checksum failed when using sha1" error (#1235), maybe a couple times per month. The --network-concurrency=1 workaround generally eliminates the symptoms, but we always have to remind people to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants