Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .pnpmrc that would override what’s specified in .npmrc #2803

Closed
ExE-Boss opened this issue Aug 27, 2020 · 2 comments
Closed

Comments

@ExE-Boss
Copy link
Member

ExE-Boss commented Aug 27, 2020

pnpm version:

5.5.3

Code to reproduce the issue:

When working on third party repositories where the main package manager is npm, it’s sometimes necessary to override pnpm‑specific options using .npmrc, but when that file is already committed to the repository, adding pnpm‑specific options to it can lead to accidentally committing them.

Using .pnpmrc and .git/info/exclude would eliminate this, as the pnpm‑specific options would be guaranteed to be local.


Yarn already does this with its .yarnrc and .yarnrc.yml.

Additional information:

  • node -v prints: v14.8.0
  • Windows, OS X, or Linux?: Windows
@zkochan
Copy link
Member

zkochan commented Jan 17, 2021

I am against this change while we still use npm's libraries for configuration. First, we need to implement our own pnpm config commands because we currently pass through to the npm CLI with those commands.

And if we use our own config system, it means that we cannot use npm CLI at all. Now we pass through many commands to npm CLI. So we'd need to reimplement all the commands.

@zkochan
Copy link
Member

zkochan commented Jan 17, 2021

also, if we decide to have our own config system, maybe we should keep all the authorization stuff inside .npmrc and move everything to a JSON or other type of file. We already have some settings in the pnpm section of package.json (pnpm.overrides).

@zkochan zkochan closed this as completed Feb 21, 2021
@pnpm pnpm locked and limited conversation to collaborators Feb 21, 2021
@zkochan zkochan unpinned this issue Feb 21, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Projects
None yet
Development

No branches or pull requests

2 participants