pnpm audit process exits before flushing stdout

[mdurling]

pnpm version: 6.7.4

Code to reproduce the issue:

import { execSync } from 'child_process'

try {
  execSync('pnpm audit --json --audit-level=low')
} catch ({ stdout }) {
  const json = stdout.toString('utf-8')
  console.log('BYTES', json.length)
  console.log('JSON', json)
}

Expected behavior:

The output of the child process running pnpm audit is available.

Actual behavior:

The output of the child process is truncated (if the output is greater than 8192 bytes).

Additional information:

This problem only seems to occur on MacOS. I believe it's because the pnpm CLI calls process.exit() prior to stdout being fully flushed. See output truncated at 8192 bytes below:

• node -v prints: v15.11.0
• Windows, macOS, or Linux?: MacOS

Here's an example of how someone else resolved using process.exitCode = 1 rather than process.exit(1).

[zkochan]

Good investigation!

Probably we can do this change

[m1heng]

should we define a specific Error for process exit, and have extra logic in packages/pnpm/src/pnpm.ts

[zkochan]

I think all the exit calls happen in this file https://github.com/pnpm/pnpm/blob/main/packages/pnpm/src/main.ts

[m1heng]

I think all the exit calls happen in this file https://github.com/pnpm/pnpm/blob/main/packages/pnpm/src/main.ts

I was think all internal exit should be replaced with throw error and being handled in pnpm.ts/pnpx.ts since they already have error handling logics.

pnpm/packages/pnpm/src/pnpm.ts

Lines 70 to 78 in 918d23d

	async function runPnpm () {
	const errorHandler = (await import('./err')).default
	try {
	const main = (await import('./main')).default
	await main(argv)
	} catch (err: any) { // eslint-disable-line
	errorHandler(err)
	}
	}

[zkochan]

No, that is not a good idea because some commands don't print an error just exit with a 1 exit code.

[m1heng]

I made a PR just fixing exit in packages/pnpm/src/main.ts.
But there are still exit logic packages/plugin-commands-publishing/src/publish.ts and packages/plugin-commands-script-runners/src/exec.ts, I am not really sure if these should be changed too.