Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to chose/change linking destination per package ie. package/dist #3540

Open
Nightreaver opened this issue Jun 16, 2021 · 0 comments

Comments

@Nightreaver
Copy link

Nightreaver commented Jun 16, 2021

Describe the user story

I am currently useing rush with pnpm and I'm having a lot of packages in out monorepo.
Mostly angularcli projects. So when using rush, its linking all the node packages to the package root (container angular.json, pacakge.json, src\ folder etc. When I build my pacakge now, its placed in .\dist\ with all compiled files and correct resolution of all paths. But the package will always be linked to project\ instead of project\dist and according to rush developer, it can only be changed if pnpm would support change the linking-path.

Without this change, I would need to "extend" my package-root package.json with types,main etc parameter that are not required there, and some package will fail anyways because of bad angular behaviour?!

Please see issue: microsoft/rushstack#728

Describe the solution you'd like

From my understanding, adding an option to change pnpm linking destination would allow to extend the linking system in rushjs, so I can make it point to any project/dist or whatever folder I need to be linked to.

Describe the drawbacks of your solution

So far, as its an additional option, I dont see any drawbacks if unused.

Describe alternatives you've considered

I haven't

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant