Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file: + shamefully-hoist not seeing deep deps change #4623

Open
farfromrefug opened this issue Apr 26, 2022 · 5 comments
Open

file: + shamefully-hoist not seeing deep deps change #4623

farfromrefug opened this issue Apr 26, 2022 · 5 comments

Comments

@farfromrefug
Copy link

I have repo with a root package json with only one dep:

"@nativescript-community/plugin-seed-tools": "file:tools"

Inside the tools folder i have a ton of dependencies.
I use shamefully-hoist so that all deps from tools are present in the top node_modules

the issue is that if i change a dep version in tools/package.json and run pnpm i in the root folder then the deps are not updated

@arpowers
Copy link

I can confirm a similar issue to this, this causes an issue for me when using Vite as it looks for dependencies to optimize in the working directory. I'm linking to another repo using link:../myrepo and while it successfully links that package, it doesn't "hoist" its dependencies.

@zkochan

@zkochan
Copy link
Member

zkochan commented May 1, 2022

@arpowers it won't work with the 'link: protocol. If you need to hoist the deps of myrepo, use the file: protocol instead.

@zkochan
Copy link
Member

zkochan commented May 1, 2022

the issue is that if i change a dep version in tools/package.json and run pnpm i in the root folder then the deps are not updated

try to run pnpm update or pnpm update @nativescript-community/plugin-seed-tools

@farfromrefug
Copy link
Author

@zkochan thanks did not know about that command.
will try.
maybe I am dumb but shouldn't this be part of install? I might be missing something but I would expect install to "update" like it would do if it sees a dep change a root level.

@farfromrefug
Copy link
Author

@zkochan i tested pnpm update and it does not seem to be doing what i expect. I can deps being updating. However if i remove deps in that sub folder and use pnpm update in the root folder which is using shamefully-hoist then the deps do not get removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants