Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update in-memory Lockfile type to v6 inline specifiers format #6342

Open
gluxon opened this issue Apr 2, 2023 · 1 comment
Open

Comments

@gluxon
Copy link
Member

gluxon commented Apr 2, 2023

In #5091, a new use-inline-specifiers-lockfile-format config was added. This was folded into the v6 lockfile format #5810, which pnpm v8 now uses by default.

For the migration process, pnpm uses the v5 lockfile format in-memory and converts to/from the v6 format when (de)serializing the lockfile.

Here's where pnpm current converts the lockfile back to the old v5 format:

const lockfileToStringify = isLockfileV6

Removing this conversion should clean up a bit of tech debt. It'll be a bit involved since it requires updating any code that depends on the Lockfile schema.

Note that we'll still need some conversion until the next major version. pnpm v8 should understand the older lockfile format so it's able to update older pnpm-lock.yaml files.

@gluxon gluxon changed the title Update in-memory Lockfile type to v6 inline specifiers format refactor: Update in-memory Lockfile type to v6 inline specifiers format Apr 2, 2023
@gluxon gluxon self-assigned this Apr 2, 2023
@gluxon
Copy link
Member Author

gluxon commented Apr 2, 2023

@zkochan Just confirming we want to do this. Wanted to make sure this was filed so I could clean up tech debt I introduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant