fix(resolve-dependencies): optimize splitNodeId, fix invalid nodeId #6755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxbodya
commented
Jul 3, 2023
| ? pkgResponse.body.id | ||
| ? `>${depPath}>` |
There was a problem hiding this comment.
this was resulting in having splitNodeId called with nodeId not having > around it, which became noticeable with the change above
zxbodya
commented
Jul 3, 2023
| @@ -18,5 +18,5 @@ export function createNodeId (parentNodeId: string, pkgId: string) { | |||
| } | |||
|
|
|||
| export function splitNodeId (nodeId: string) { | |||
| return nodeId.slice(1, -1).split('>') | |||
| return nodeId.split('>').slice(1, -1) | |||
There was a problem hiding this comment.
having a slice after splitting the string, allows copying less data, making the dependency resolution a few seconds faster on a large monorepo
zkochan
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to avoid creating invalid nodeId, small optimization