Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Give confirmation of patched packages #7613

Open
1 task done
ivnnv opened this issue Feb 3, 2024 · 4 comments
Open
1 task done

[FEAT] Give confirmation of patched packages #7613

ivnnv opened this issue Feb 3, 2024 · 4 comments

Comments

@ivnnv
Copy link

ivnnv commented Feb 3, 2024

Contribution

Describe the user story

Hi, it seems theres indeed a message logged when any patches havent been applied:
The following patches were not applied

Describe the solution you'd like

It would be nice to also log when patches have been applied a-la patch-package as it gives you peace of mind when you read it (specially on CI/CD environments).

Describe the drawbacks of your solution

I dont think theres any drawbacks on having just a new log line on install

Describe alternatives you've considered

this is pretty straightforward, the alternative is just switch back to patch-package lol

@zkochan
Copy link
Member

zkochan commented Feb 3, 2024

What does patch-package print out?

@ivnnv
Copy link
Author

ivnnv commented Feb 5, 2024

hey @zkochan, thanks for the early response, this is the output:

> patch-package

patch-package 8.0.0
Applying patches...
bull-arena@4.1.0 ✔

@ivnnv
Copy link
Author

ivnnv commented Feb 12, 2024

@zkochan friendly ping, I could be able to implement this feature if its just loggin here

@zkochan
Copy link
Member

zkochan commented Feb 12, 2024

ok, go ahead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants