Fix (or document changes in) "file:" protocol

[artemis-prime]

Verify latest release

• I verified that the issue exists in the latest pnpm release

pnpm version

9

Which area(s) of pnpm are affected? (leave empty if unsure)

Dependencies resolver

Link to the code that reproduces this issue or a replay of the bug

No response

Reproduction steps

try to use 'file:../../path/to/some/modude' which now fails.

Describe the Bug

// root package.json

"pnpm": {
    "overrides": {
        "@mydomain/moduleName": "file:../../myOtherDomain/otherModuleName"

    }
  }

In 8.x, this is the main way that I used to do local dev on local modules (not in the host monorepo)

in 9.x, this produces:

 ERR_PNPM_LINKED_PKG_DIR_NOT_FOUND  Could not install from "/home//mydoamin/monorepo/otherdomain/othermodulename/" as it does not exist.
 
 (ie, it's not even concatenating the filenames correctly!)
 
 Also, any mention of the "file:" protocol seems to be gone from the docs

Expected Behavior

Should install and use the module as specified with "file:" above.

Which Node.js version are you using?

18

Which operating systems have you used?

• macOS
• Windows
• Linux

If your OS is a Linux based, which one it is? (Include the version if relevant)

Mint 20

[zkochan]

@KSXGitHub could this be related to the fix you did?

[KSXGitHub]

@zkochan It's hard to say. I cannot reproduce the bug with pd.

Here's my package.json:

{
  "private": true,
  "dependencies": {
    "@pnpm/tabtab": "*"
  },
  "pnpm": {
    "overrides": {
      "@pnpm/tabtab": "file:../../programming/pnpm-tabtab"
    }
  }
}

[KSXGitHub]

And I cannot reproduce the bug with the latest release of pnpm (v9.0.6) either

[cognvn]

I have same issue with monorepo + pnpm.overrides.
Here is the demo repo reproducing the bug: https://github.com/cognvn/demo-pmpm-issue
In this example, I use @pnpm/types in workspaces apps/web and packages/ui, then overrride "@pnpm/types": "file:./tarball/pnpm-types-10.0.0.tgz" in root workspace

This commit 04310be fix absolute path issue but lost relation to root workspace directory.
How about resolving it like link: protocol:

pnpm/hooks/read-package-hook/src/createVersionsOverrider.ts

Lines 100 to 111 in 88f53d4

	if (versionOverride.linkTarget && dir) {
	deps[versionOverride.targetPkg.name] = `link:${normalizePath(
	path.relative(dir, versionOverride.linkTarget)
	)}`
	continue
	}
	if (versionOverride.linkFileTarget) {
	deps[
	versionOverride.targetPkg.name
	] = `file:${versionOverride.linkFileTarget}`
	continue
	}

[KSXGitHub]

I have created #8055