Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP2 performance and multiple concurrency #88

Closed
gunta opened this issue Feb 4, 2016 · 9 comments
Closed

HTTP2 performance and multiple concurrency #88

gunta opened this issue Feb 4, 2016 · 9 comments

Comments

@gunta
Copy link

gunta commented Feb 4, 2016

Hi!

I'm currently using an internal npm registry.

Do you think it would be worth exploring the possibility of making this HTTP2 enabled?
This may allow for infinite concurrency with no penalty.

For example we could use this for server/client: https://github.com/molnarg/node-http2

@rstacruz
Copy link
Member

rstacruz commented Feb 4, 2016

That'd be interesting. We're currently using got, but not by much, so it might be easy to switch to http2 with possible http fallback.

If there's a package that already handles this, lemme know (I don't know of any!). PR's are also welcome.

@gunta
Copy link
Author

gunta commented Feb 4, 2016

Unfortunately there is no package that wraps this.

I've created an Issue for GOT here:
sindresorhus/got#167

Otherwise, we would have to use is-http2 along with node-http2.
https://github.com/stefanjudis/is-http2

Or create a new package.

@gunta
Copy link
Author

gunta commented Feb 4, 2016

Ok seems that its gonna be easier to fix on the GOT side.

However we might add here the spdy module as a dependency in pnpm to have HTTP2 support enabled by default.

@zkochan
Copy link
Member

zkochan commented Oct 5, 2016

@gunta we now use the same package that npm uses to make http requests (https://github.com/npm/npm-registry-client). Do you think this issue is still relevant?

@gunta
Copy link
Author

gunta commented Oct 6, 2016

@zkochan Still relevant. They use request which doesn't support http2 neither.

Since it doesn't looks too difficult, we could hack something like this in the meantime: http://stackoverflow.com/questions/37653110/is-there-a-request-like-package-using-http2

@zkochan
Copy link
Member

zkochan commented Oct 6, 2016

I see. We can try to make a pull request to npm-registry-client. If they won't accept it, we can fork it and use the fork.

@DanielRuf
Copy link
Contributor

DanielRuf commented Jul 8, 2018

Is this still relevant? Node 10 (and probably earlier releases) supports http2 internally (at least "experimental").

https://nodejs.org/api/http2.html#http2_http_2

@aparajita
Copy link
Contributor

@zkochan Do you still want to consider this? Since node-fetch doesn't seem to support http2, it would mean switching to something like fetch-h2.

@zkochan
Copy link
Member

zkochan commented Aug 5, 2020

sure, would be nice to see if we get a performance boost with that library.

@zkochan zkochan closed this as completed Feb 21, 2021
@pnpm pnpm locked and limited conversation to collaborators Feb 21, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Projects
None yet
Development

No branches or pull requests

5 participants