Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't use the built-in TimeoutError #49

Open
terrdavis opened this issue Jul 17, 2018 · 4 comments
Open

Doesn't use the built-in TimeoutError #49

terrdavis opened this issue Jul 17, 2018 · 4 comments

Comments

@terrdavis
Copy link

Why don't you use the built-in exception?

@majiang
Copy link

majiang commented Apr 11, 2021

The reason I think is that built-in TimeoutError is "Raised when a system function timed out at the system level.

Besides, using the same name TimeoutError seems error-prone (that's why I searched the issues for the name and found this one).

@bfontaine
Copy link

It might be a good solution to use something like class TimeoutDecoratorError(TimeoutError): a class with a different name that inherits from the built-in exception.

@majiang
Copy link

majiang commented Apr 24, 2021

If you inherited you would say "a TimeoutDeoratorError is a TimeoutError" which is system level by built-in definition. We should rather just rename the TimeoutError to a non-confusing alternative.

@bfontaine
Copy link

That’s true. requests uses Timeout to avoid the confusion with the built-in TimeoutError.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants