Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The thumbnail gets stuck when the mouse is moved repeatedly on the timeline #5

Closed
natural-harmonia-gropius opened this issue Sep 20, 2022 · 2 comments

Comments

@natural-harmonia-gropius
Copy link
Contributor

#4 mitigated the issue, but does not solve it.

Drifting.Home.2022.1080p.NF.WEB-DL.DUAL.DDP5.1.H.264-SMURF.mkv.-.mpv.2022-09-20.17-47-27_Trim.mp4
@dyphire
Copy link
Contributor

dyphire commented Sep 20, 2022

Can be reproduced on Windows.

@po5
Copy link
Owner

po5 commented Sep 20, 2022

I'm aware of it, it's caused by the retry mechanism not re-rendering the existing finished thumbnail at the new position, if one exists.

thumbfast/thumbfast.lua

Lines 303 to 314 in 9970e44

local info = mp.utils.file_info(options.thumbnail)
if not info or info.size ~= thumb_size then
if thumbtime == -1 then
can_generate = true
return
end
if thumbtime < 0 then
thumbtime = thumbtime + 1
end
-- retry up to 5 times
return mp.add_timeout(0.05, function() display_img(w, h, thumbtime < 0 and thumbtime or -5, display_time, script) end)
end

Should be able to fix this in a couple hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants