Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To many events queued #90

Closed
natural-harmonia-gropius opened this issue May 11, 2023 · 15 comments
Closed

To many events queued #90

natural-harmonia-gropius opened this issue May 11, 2023 · 15 comments

Comments

@natural-harmonia-gropius
Copy link
Contributor

Using latest version.

image

@po5
Copy link
Owner

po5 commented May 11, 2023

Any more details? Were thumbnails working for a few seconds, minutes?
Did you have to hover the timeline a bunch to trigger this?

@natural-harmonia-gropius
Copy link
Contributor Author

few seconds

2023-05-11.170931.mp4

@po5
Copy link
Owner

po5 commented May 11, 2023

Does reverting 7d813a9 fix it?

@natural-harmonia-gropius
Copy link
Contributor Author

No

@po5
Copy link
Owner

po5 commented May 11, 2023

Max is 1000 events, it couldn't possibly be coming from our observed properties, must be some recursion somewhere.
Can you try removing or (rotate == nil and not disabled)? This is the most obvious cause I can think of.

@natural-harmonia-gropius
Copy link
Contributor Author

Not fix.
And freeze happens before error message.

@christoph-heinrich
Copy link
Contributor

If it's some recursion somewhere, you can try finding it with print(debug.traceback())

@po5
Copy link
Owner

po5 commented May 11, 2023

Reverted until I can reproduce this and figure it out, use the observe-properties branch if you want to take a crack at it.

@hooke007
Copy link
Contributor

And freeze happens before error message.

Yes, I never saw any error in console but thumbnail just quickliy lost response.

@hooke007
Copy link
Contributor

@po5 Freezing was introduced by be884c6

@po5
Copy link
Owner

po5 commented May 11, 2023

Weird, surely it's possible to keep the Windows socket open. I'll try booting into Windows.

@po5
Copy link
Owner

po5 commented May 11, 2023

Turns out the pipe just stops responding after we send it 4096 bytes of data. Gotta love Windows.
I'll reopen the file every time we hit 4096 bytes, problem solved and we keep the speedup of reopening a file, most of the time.

@po5
Copy link
Owner

po5 commented May 12, 2023

Should be fixed?

@N-R-K
Copy link
Contributor

N-R-K commented May 12, 2023

Turns out the pipe just stops responding after we send it 4096 bytes of data. Gotta love Windows.

That can also happen on linux/posix if the other end isn't draining the pipe (although PIPE_MAX is typically higher than 4KiB, at least on linux). Or are you saying it stops after sending 4KiB in total - regardless of whether the other end drained it or not?

@po5
Copy link
Owner

po5 commented May 12, 2023

Total, the pipe seems to never clear. I tried different opening modes.
If you know a way to get it to work, that would obviously be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants