Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subcommand suggestion #659

Merged
merged 6 commits into from Jul 24, 2022
Merged

Fix subcommand suggestion #659

merged 6 commits into from Jul 24, 2022

Conversation

wx257osn2
Copy link
Contributor

  • suggest subcommand even with flags/options
    • see poac -v seach , current poac doesn't suggest search
  • stop subcommand suggestion if subcommand is correct
    • see poac search , current poac suggest search even though the subcommand is correct

Copy link
Member

@ken-matsui ken-matsui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to create this PR!

Here are just nitpicks

src/main.cc Outdated Show resolved Hide resolved
src/main.cc Outdated Show resolved Hide resolved
src/main.cc Outdated Show resolved Hide resolved
Co-authored-by: Ken Matsui <26405363+ken-matsui@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jul 23, 2022

Codecov Report

Merging #659 (099a57d) into main (8c761fd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #659   +/-   ##
=======================================
  Coverage   98.16%   98.16%           
=======================================
  Files          52       52           
  Lines        2502     2502           
=======================================
  Hits         2456     2456           
  Misses         46       46           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c761fd...099a57d. Read the comment docs.

wx257osn2 and others added 2 commits July 24, 2022 07:38
Co-authored-by: Ken Matsui <26405363+ken-matsui@users.noreply.github.com>
Co-authored-by: Ken Matsui <26405363+ken-matsui@users.noreply.github.com>
Copy link
Member

@ken-matsui ken-matsui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better. Thank you for your contribution! :)

@ken-matsui ken-matsui enabled auto-merge (squash) July 23, 2022 23:30
@ken-matsui ken-matsui merged commit ec13052 into main Jul 24, 2022
@ken-matsui ken-matsui deleted the fix-subcommand-suggestion branch July 24, 2022 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants