Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Top Accounts listing performance #873

Closed
gfreh opened this issue Oct 5, 2018 · 16 comments
Closed

Improve Top Accounts listing performance #873

gfreh opened this issue Oct 5, 2018 · 16 comments
Assignees
Labels

Comments

@gfreh
Copy link

gfreh commented Oct 5, 2018

Description

Loading the Top Accounts list is very slow.

Also, after the page is loaded, the count of transactions per account seems to be wrong.

Steps to Reproduce

Visit: https://blockscout.com/eth/mainnet/accounts

During the standup meeting (11/06/18) we commonly agreed that some changes were needed to enable this query (list_top_addresses) on the mainnet. In this agreement, we decided to simplify the query by removing the transaction count from it and also adding a new index to improve its performance.

The previous test result using the mainnet can be consulted in this PR: #1040

Acceptance Criteria

  1. Be able to execute the query on the mainnet database as well;
  2. Be able to load the Top Accounts listing page again without returning a Gateway Timeout error;
@gfreh gfreh created this issue from a note in Developers Section (Refining) Oct 5, 2018
@gfreh gfreh added enhancement New feature or request team: developer priority: critical 🔨 Urgent issues. labels Oct 5, 2018
@mkosowsk
Copy link

From @acravenho

The accounts page loads very slow. This page is currently disabled and we would like to enable the page. We are currently increasing the speed for the count transaction query which should speed up the page some. Please try to avoid any modifications which would require a db reset.

Best of luck, bounty hunters!

@gitcoinbot
Copy link

@WiechersV Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

2 similar comments
@gitcoinbot
Copy link

@WiechersV Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@WiechersV Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@rmshea
Copy link

rmshea commented Oct 25, 2018

Hey @WiechersV, are you still working on this issue? Let me know 😄

@gitcoinbot
Copy link

@WiechersV Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

2 similar comments
@gitcoinbot
Copy link

@WiechersV Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@WiechersV Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@rmshea
Copy link

rmshea commented Oct 29, 2018

Hey @WiechersV, going to open this back up to the rest of the community!

@svenski123
Copy link
Contributor

I've submitted #1040 which reduces the accounts page rendering time from minutes to a second or so.

Despite the improved DB querying, htting the transactions table just to get the highest nonce will get more expensive as the table grows. I would suggest adding a nonce column to the addresses table and updating that when transactions are imported. I note the addresses table already has values effectively cacheing transaction state (i.e. fetched_coin_balance, etc.).

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 75.0 DAI (75.0 USD @ $1.0/DAI) has been submitted by:

  1. @svenski123

@mkosowsk please take a look at the submitted work:


@feliperenan feliperenan moved this from Refining to Ready to Do in Developers Section Nov 6, 2018
@vs77bb
Copy link

vs77bb commented Nov 8, 2018

@mkosowsk looks like this one may be good for payout 👍

@svenski123
Copy link
Contributor

I've marked myself as stop work on this as the PR branch is done and has been merged into the project.
Please kindly pay out the bounty.
@mkosowsk

@mkosowsk
Copy link

@svenski123 paid out! Thanks for your contribution :)

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 75.0 DAI (75.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @svenski123.

@amandasposito amandasposito moved this from Ready to Do to In progress in Developers Section Nov 12, 2018
@brwatanabe brwatanabe moved this from In progress to In Review in Developers Section Nov 13, 2018
@amandasposito amandasposito self-assigned this Nov 26, 2018
@brwatanabe brwatanabe moved this from In Review to Done in Developers Section Nov 27, 2018
@amandasposito
Copy link
Contributor

Closed via #1140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

8 participants