New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Top Accounts listing performance #873
Comments
From @acravenho
Best of luck, bounty hunters! |
@WiechersV Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
2 similar comments
@WiechersV Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
@WiechersV Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
Hey @WiechersV, are you still working on this issue? Let me know 😄 |
@WiechersV Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
2 similar comments
@WiechersV Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
@WiechersV Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
Hey @WiechersV, going to open this back up to the rest of the community! |
I've submitted #1040 which reduces the accounts page rendering time from minutes to a second or so. Despite the improved DB querying, htting the transactions table just to get the highest nonce will get more expensive as the table grows. I would suggest adding a nonce column to the addresses table and updating that when transactions are imported. I note the addresses table already has values effectively cacheing transaction state (i.e. fetched_coin_balance, etc.). |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work for 75.0 DAI (75.0 USD @ $1.0/DAI) has been submitted by: @mkosowsk please take a look at the submitted work:
|
@mkosowsk looks like this one may be good for payout 👍 |
I've marked myself as stop work on this as the PR branch is done and has been merged into the project. |
@svenski123 paid out! Thanks for your contribution :) |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done The funding of 75.0 DAI (75.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @svenski123.
|
Closed via #1140 |
Description
Loading the Top Accounts list is very slow.
Also, after the page is loaded, the count of transactions per account seems to be wrong.
Steps to Reproduce
Visit: https://blockscout.com/eth/mainnet/accounts
During the standup meeting (11/06/18) we commonly agreed that some changes were needed to enable this query (list_top_addresses) on the mainnet. In this agreement, we decided to simplify the query by removing the transaction count from it and also adding a new index to improve its performance.
The previous test result using the mainnet can be consulted in this PR: #1040
Acceptance Criteria
Gateway Timeout
error;The text was updated successfully, but these errors were encountered: