Chunk JSON-RPC batches in case connection times out #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There exists code to ensure long-running batch requests are split into smaller batches in case we receive 504 (Gateway Timeout) errorfrom loadbalancer. This PR adds handling of batches in the same manner in case there either is no balancer, or its timeouts are configured larger than indexer's, and thus the HTTP client library itself times out.
ghost
assigned 
goodsoft
added
ready for review
ayrat555
reviewed
Mar 18, 2019
| @@ -189,6 +189,98 @@ defmodule EthereumJSONRPC.HTTP.MoxTest do | |||
|
|
|||
| assert MapSet.equal?(response_block_number_set, block_number_set) | |||
| end | |||
|
|
|||
| @tag :no_geth | |||
| # Regression test for https://github.com/poanetwork/blockscout/issues/418 | |||
ayrat555
reviewed
Mar 18, 2019
|
|
||
| @tag :no_geth | ||
| # Regression test for https://github.com/poanetwork/blockscout/issues/418 | ||
| test "transparently splits batch payloads that would trigger a request timeout", %{ |
There was a problem hiding this comment.
this test is using Mox for mocking HTTP requests. Can you please describe how HTTP timeout is simulated as described in the test's description
Pull Request Test Coverage Report for Build b8126845-f21a-4fe2-a7b8-ea5e81c7c5c6
💛 - Coveralls |
ayrat555
approved these changes
Mar 19, 2019
vbaranov
approved these changes
Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There exists code to ensure long-running batch requests are split into smaller
batches in case we receive 504 (Gateway Timeout) errorfrom loadbalancer.
This PR adds handling of batches in the same manner in case there either is no
balancer, or its timeouts are configured larger than indexer's, and thus the
HTTP client library itself times out.