Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve chains menu #1849

Merged
merged 6 commits into from Apr 30, 2019
Merged

Improve chains menu #1849

merged 6 commits into from Apr 30, 2019

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Apr 26, 2019 •
edited

Motivation

Make dropdown more systematized and user-friendly

Changelog

  • divide mainnets to head and other supported chains
  • remove hover event form header
  • change padding for headers

Enhancements

The current dropdown:

Screenshot 2019-04-26 at 18 08 11

The dropdown after changes:

Screenshot 2019-04-26 at 18 10 17

  • I added an entry to CHANGELOG.md with this PR
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so if necessary

@ghost ghost assigned vbaranov Apr 26, 2019
@ghost ghost added the in progress label Apr 26, 2019
@vbaranov vbaranov added ready for review This PR is ready for reviews. and removed in progress labels Apr 26, 2019
@coveralls
Copy link

coveralls commented Apr 26, 2019 •
edited

Pull Request Test Coverage Report for Build 5b810602-3c93-4ee9-ac44-6cba48ba712c

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 82.231%
Totals Coverage Status
Change from base Build 4b768b94-e385-499b-b180-e07449b9f058: 0.3%
Covered Lines: 4475
Relevant Lines: 5442
💛 - Coveralls

@ghost ghost added the in progress label Apr 29, 2019
@goodsoft
Copy link
Contributor

I think it would look a bit better either with top block aligned to the left to match subheader alignment, or with another subheader for top block as well.

@vbaranov
Copy link
Member Author

@goodsoft tnx for comment. I've added top header:

Screenshot 2019-04-30 at 14 04 24

@vbaranov vbaranov merged commit 9edfc9e into master Apr 30, 2019
@ghost ghost removed the in progress label Apr 30, 2019
@vbaranov vbaranov deleted the improve-menu branch April 30, 2019 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodsoft goodsoft goodsoft approved these changes

@saneery saneery saneery approved these changes

@zachdaniel zachdaniel Awaiting requested review from zachdaniel

Assignees

@vbaranov vbaranov

Labels
ready for review This PR is ready for reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vbaranov @coveralls @goodsoft @saneery