Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) Wrong styles for tokens dropdown #1944

Merged
merged 4 commits into from May 15, 2019
Merged

(fix) Wrong styles for tokens dropdown #1944

merged 4 commits into from May 15, 2019

Conversation

gabitoesmiapodo
Copy link
Contributor

@gabitoesmiapodo gabitoesmiapodo commented May 13, 2019 •
edited

Closes #1935

Motivation

Fix the dropdown's styles.

Should look like this now:

Screen Shot 2019-05-13 at 20 45 22

Changelog

Bug Fixes

  • Fixed styles for token's dropdown.

Checklist for your PR

  • I added an entry to CHANGELOG.md with this PR
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so if necessary

@gabitoesmiapodo gabitoesmiapodo self-assigned this May 13, 2019
@ghost ghost added the in progress label May 13, 2019
@coveralls
Copy link

coveralls commented May 14, 2019 •
edited

Pull Request Test Coverage Report for Build d50acef4-e4cc-4c5b-8ae7-5f343c2c6c56

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 81.85%
Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/fetcher/replaced_transaction.ex 2 90.91%
Totals Coverage Status
Change from base Build 3d44a9ab-5bfd-49f1-b9eb-b272c281eebb: -0.04%
Covered Lines: 4654
Relevant Lines: 5686
💛 - Coveralls

vbaranov
vbaranov reviewed May 14, 2019
View reviewed changes
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest looks good.

apps/block_scout_web/lib/block_scout_web/templates/address_token_balance/_tokens.html.eex Outdated Show resolved Hide resolved
@gabitoesmiapodo
(fix) remove text
750a665
@gabitoesmiapodo
Merge branch 'master' into fix/#1935-wrong-styles-for-tokens-dropdown
a5cb7ab 
* master: (22 commits)
  Update CHANGELOG.md
  Add files via upload
  Update _goerli_variables.scss
  feat: exclude empty contracts by default
  Fix gettext test
  (fix) balance section pagination position
  (fix) little refactoring
  (fix) "next / older" pagination button
  (fix) pagination alignment
  Update CHANGELOG.md
  Update ropsten_logo.svg
  Update _ropsten_variables.scss
  (update) internationalization files
  (update) all pagination buttons in all sections
  feat: add on demand fetching and stale attr to rpc
  Add CHANGELOG entry
  check presence of overlap[i]
  (update) changelog
  (fix) syntax
  (add) internationalization for pagination
  ...
@vbaranov vbaranov merged commit dfec140 into master May 15, 2019
@vbaranov vbaranov deleted the fix/#1935-wrong-styles-for-tokens-dropdown branch May 15, 2019 15:22
@ghost ghost removed the in progress label May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachdaniel zachdaniel zachdaniel approved these changes

@ayrat555 ayrat555 ayrat555 approved these changes

@saneery saneery saneery approved these changes

@vbaranov vbaranov Awaiting requested review from vbaranov

Assignees

@gabitoesmiapodo gabitoesmiapodo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong styles for tokens dropdown
6 participants
@gabitoesmiapodo @coveralls @vbaranov @zachdaniel @ayrat555 @saneery