Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New xUSDT theme created. #2672

Merged
merged 8 commits into from Sep 6, 2019
Merged

Conversation

YegorSan
Copy link
Contributor

@YegorSan YegorSan commented Sep 5, 2019

This PR is related to #2664 issue.

Motivation

New layout for xUSDT theme was needed.

Changelog

Enhancements

Created a new theme for xUSDT:

screencapture-localhost-4000-2019-09-05-23_16_03

And dark mode:
screencapture-localhost-4000-2019-09-05-23_33_45

Checklist for your PR

@YegorSan
Copy link
Contributor Author

YegorSan commented Sep 6, 2019

@vbaranov Hello Victor. I want to clarify one question. As far as I can see , logic for rendering logo written in embedded elixir syntax:

<img class="navbar-logo" id="navbar-logo" src="<%= logo() %>" alt="<%= subnetwork_title() %>" />

I've created new theme and uploaded logos, please confirm, that no additional steps must be performed from my end. Thank's in advance.

@vbaranov vbaranov self-requested a review September 6, 2019 11:35
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YegorSan

You forgot to add a commented non-critical css to ./assets/css/theme/_variables-non-critical.scss

Question: You didn't provide updates for network selector to support this instance. Is it implied to add this chain to the network menu? if yes, some elements are missing:

  • network icon for network selector
  • css class for icon
  • preload of that icon in ./assets/css/_images-preload.scss

@vbaranov
Copy link
Member

vbaranov commented Sep 6, 2019

@YegorSan in addition to my review, CHANGELOG entry is missing

@YegorSan
Copy link
Contributor Author

YegorSan commented Sep 6, 2019

@vbaranov Hello. You are absolutely right. I've just created the new theme, but didn't add any additional changes to network selector yet, as it wasn't mentioned in this issue. Let me work on it right now. I'll take a further look and provide an update shortly.

@YegorSan
Copy link
Contributor Author

YegorSan commented Sep 6, 2019

@vbaranov I've added new icons in styles for xUSDT, commented line to non-critical css, style for preload and style for icon. Please review. Thank you in advance.

@@ -280,6 +280,9 @@ $network-selector-item-icon-dimensions: 30px !default;
&-lukso-l14-testnet {
background-image: url(/images/network-selector-icons/lukso-l14-testnet.svg)
}
&-xusdt-mainnet {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YegorSan please change the class name from &-xusdt-mainnet to &-xusdt-chain to conform it with xDai Chain

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vbaranov Please give me a few minutes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vbaranov Done. Please check.

@vbaranov vbaranov self-requested a review September 6, 2019 16:12
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YegorSan looks good now

@vbaranov vbaranov merged commit 36a421b into blockscout:master Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants