Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch token counters async #2776

Merged
merged 9 commits into from Oct 23, 2019

Conversation

@ayrat555
Copy link
Member

ayrat555 commented Oct 14, 2019

resolves #2771

Motivation

Token counters fetching is the slowest part of the token page.

Changelog

  • fetch token counters async
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 14, 2019

Pull Request Test Coverage Report for Build d5b29d90-2d0e-456b-ad23-ad7d554edb59

  • 8 of 10 (80.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 77.56%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/block_scout_web/lib/block_scout_web/controllers/tokens/token_controller.ex 4 5 80.0%
apps/block_scout_web/lib/block_scout_web/controllers/tokens/transfer_controller.ex 0 1 0.0%
Totals Coverage Status
Change from base Build 7d50efc0-c117-4ad8-82ca-64642d98176f: 0.4%
Covered Lines: 5333
Relevant Lines: 6876

💛 - Coveralls
ayrat555 added 6 commits Oct 15, 2019
@ayrat555 ayrat555 changed the title [WIP] fetch token counters async fetch token counters async Oct 17, 2019
@ayrat555 ayrat555 requested review from vbaranov and pasqu4le Oct 17, 2019
@vbaranov vbaranov merged commit 46e95a1 into master Oct 23, 2019
15 checks passed
15 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check_formatted Your tests passed on CircleCI!
Details
ci/circleci: coveralls_merge Your tests passed on CircleCI!
Details
ci/circleci: credo Your tests passed on CircleCI!
Details
ci/circleci: dialyzer Your tests passed on CircleCI!
Details
ci/circleci: eslint Your tests passed on CircleCI!
Details
ci/circleci: gettext Your tests passed on CircleCI!
Details
ci/circleci: jest Your tests passed on CircleCI!
Details
ci/circleci: release Your tests passed on CircleCI!
Details
ci/circleci: sobelow Your tests passed on CircleCI!
Details
ci/circleci: test_geth_http_websocket Your tests passed on CircleCI!
Details
ci/circleci: test_geth_mox Your tests passed on CircleCI!
Details
ci/circleci: test_parity_http_websocket Your tests passed on CircleCI!
Details
ci/circleci: test_parity_mox Your tests passed on CircleCI!
Details
coverage/coveralls Coverage increased (+0.4%) to 77.56%
Details
@vbaranov vbaranov deleted the ab-fetch-token-counters-async branch Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.