Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFT instance: link to the app #3279

Merged
merged 5 commits into from Sep 3, 2020
Merged

NFT instance: link to the app #3279

merged 5 commits into from Sep 3, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Sep 3, 2020

Motivation

Add a link to the app for NFT token if applicable.

Changelog

Find external_url property in tokenURI json and add a link to token instance page with its value

Screenshot 2020-09-03 at 11 02 33

Checklist for your Pull Request (PR)

@vbaranov vbaranov changed the title NFT link to the app NFT token instance: link to the app Sep 3, 2020
@vbaranov vbaranov force-pushed the vb-nft-external-link branch 2 times, most recently from e609d61 to 77347de Compare September 3, 2020 08:09
@coveralls
Copy link

coveralls commented Sep 3, 2020

Pull Request Test Coverage Report for Build 1a0dd2432fbde91baee7fa87bc086cff1e847848-PR-3279

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 20 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+10.6%) to 75.836%

Files with Coverage Reduction New Missed Lines %
lib/block_scout_web/views/tokens/instance/overview_view.ex 20 24.39%
Totals Coverage Status
Change from base Build e29804af4b8a110eda68e64315fbe88e11163d06: 10.6%
Covered Lines: 1927
Relevant Lines: 2541

💛 - Coveralls

@vbaranov vbaranov changed the title NFT token instance: link to the app NFT instance: link to the app Sep 3, 2020
@vbaranov vbaranov merged commit 8cffbd7 into master Sep 3, 2020
@vbaranov vbaranov deleted the vb-nft-external-link branch September 3, 2020 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants