Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set infinity timeout and increase cache invalidation period for counters on the main page #3446

Merged
merged 2 commits into from Nov 11, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Nov 10, 2020

Motivation

Default cache invalidation interval is too small for counters on the main page and request is dropped after 1 minute

Changelog

Increase default cache invalidation interval up to 15 minutes, set an infinite timeout for counters queries.

Checklist for your Pull Request (PR)

@vbaranov vbaranov force-pushed the vb-change-default_ttl_check_interval branch from 436de3f to fd2f868 Compare November 10, 2020 20:08
@coveralls
Copy link

coveralls commented Nov 10, 2020

Pull Request Test Coverage Report for Build 14466f5390c0521b3c08e080118ef2373efb63bf-PR-3446

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.8%) to 67.433%

Files with Coverage Reduction New Missed Lines %
lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 1 78.57%
Totals Coverage Status
Change from base Build e0b276e1113fb0c69bc1400254596cbfa0e53fae: 0.8%
Covered Lines: 2054
Relevant Lines: 3046

💛 - Coveralls

@vbaranov vbaranov force-pushed the vb-change-default_ttl_check_interval branch 2 times, most recently from f7f3924 to 3b8ba7f Compare November 11, 2020 14:55
@vbaranov vbaranov changed the title Change default ttl_check_interval for counters on the main page Set infinity timeout for counters on the main page Nov 11, 2020
@vbaranov vbaranov changed the title Set infinity timeout for counters on the main page Set infinity timeout and increase cache invalidation period for counters on the main page Nov 11, 2020
@vbaranov vbaranov force-pushed the vb-change-default_ttl_check_interval branch from 3b8ba7f to 14466f5 Compare November 11, 2020 15:04
@vbaranov vbaranov merged commit f3e4e00 into master Nov 11, 2020
@vbaranov vbaranov deleted the vb-change-default_ttl_check_interval branch November 11, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants