Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Staking DApp scripts due to MetaMask breaking changes #3460

Merged
merged 4 commits into from Nov 19, 2020

Conversation

varasev
Copy link
Contributor

@varasev varasev commented Nov 18, 2020

Motivation

There are MetaMask breaking changes: https://docs.metamask.io/guide/provider-migration.html

This PR uses the latest changes for Staking DApp JavaScript code.

Checklist for your Pull Request (PR)

@coveralls
Copy link

coveralls commented Nov 18, 2020

Pull Request Test Coverage Report for Build 0f8b91cc7ffe1f5760681986b284011c5b2db6c1-PR-3460

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.5%) to 67.103%

Files with Coverage Reduction New Missed Lines %
lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 1 78.57%
lib/block_scout_web/checksum_address.ex 6 55.56%
Totals Coverage Status
Change from base Build 84741f3db5aba428c7820153579840f2aa4e790a: -1.5%
Covered Lines: 2052
Relevant Lines: 3058

💛 - Coveralls

Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor improvements suggestions

apps/block_scout_web/assets/js/pages/stakes.js Outdated Show resolved Hide resolved
apps/block_scout_web/assets/js/pages/stakes.js Outdated Show resolved Hide resolved
apps/block_scout_web/assets/js/pages/stakes.js Outdated Show resolved Hide resolved
apps/block_scout_web/assets/js/pages/stakes.js Outdated Show resolved Hide resolved
apps/block_scout_web/assets/js/pages/stakes.js Outdated Show resolved Hide resolved
apps/block_scout_web/assets/js/pages/stakes/make_stake.js Outdated Show resolved Hide resolved
apps/block_scout_web/assets/js/pages/stakes/utils.js Outdated Show resolved Hide resolved
@varasev
Copy link
Contributor Author

varasev commented Nov 19, 2020

@vbaranov I made refactorings you proposed above in 2edb8ce.

Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. I notice that one more message could be placed into constants.

apps/block_scout_web/assets/js/pages/stakes.js Outdated Show resolved Hide resolved
@vbaranov vbaranov merged commit 6b1e69b into master Nov 19, 2020
@vbaranov vbaranov deleted the va-staking-dapp-metamask-provider-updated branch November 19, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants